Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34743 )
Change subject: mb/google/hatch/variants/helios: Update DPTF parameters and TDP PL1/PL2
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34743/1/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/variants/helios/include/variant/acpi/dptf.asl:
https://review.coreboot.org/c/coreboot/+/34743/1/src/mainboard/google/hatch/...
PS1, Line 36: 8000
Is this correct?
https://review.coreboot.org/c/coreboot/+/34743/1/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/variants/helios/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/34743/1/src/mainboard/google/hatch/...
PS1, Line 2: 8
Shouldn't this be 13W?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34743
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic7a96c33ce710c32b57e2ad8066830ff83398c57
Gerrit-Change-Number: 34743
Gerrit-PatchSet: 1
Gerrit-Owner: Frank Chu
frank_chu@pegatron.corp-partner.google.com
Gerrit-Reviewer: Frank Chu
frank_chu@pegatron.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Philip Chen
philipchen@google.com
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-CC: Kane Chen
kane_chen@pegatron.corp-partner.google.com
Gerrit-CC: Ken Lu
ken_lu@pegatron.corp-partner.google.com
Gerrit-Comment-Date: Wed, 07 Aug 2019 23:17:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment