Change in coreboot[master]: include/cpu/x86/lapic.h: Remove unused '#include <smp/node.h>'

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36373 )

Change subject: include/cpu/x86/lapic.h: Remove unused '#include <smp/node.h>'
......................................................................

include/cpu/x86/lapic.h: Remove unused '#include <smp/node.h>'

Change-Id: Icdd6b49751763ef0edd4c57e855cc1d042dc6d4d
Signed-off-by: Elyes HAOUAS 
---
M src/include/cpu/x86/lapic.h
1 file changed, 0 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/36373/1

diff --git a/src/include/cpu/x86/lapic.h b/src/include/cpu/x86/lapic.h
index 6fd1997..f8081b5 100644
--- a/src/include/cpu/x86/lapic.h
+++ b/src/include/cpu/x86/lapic.h
@@ -4,7 +4,6 @@
 #include <cpu/x86/lapic_def.h>
 #include <cpu/x86/msr.h>
 #include <halt.h>
-#include <smp/node.h>

static __always_inline unsigned long lapic_read(unsigned long reg)
 {

Change in coreboot[master]: src: Use '#include <smp/node.h>' when when appropriate

[HAOUAS Elyes (Code Review)]

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/36373

to look at the new patch set (#2).

Change subject: src: Use '#include <smp/node.h>' when when appropriate
......................................................................

src: Use '#include <smp/node.h>' when when appropriate

Change-Id: Icdd6b49751763ef0edd4c57e855cc1d042dc6d4d
Signed-off-by: Elyes HAOUAS 
---
M src/cpu/intel/fsp_model_406dx/model_406dx_init.c
M src/cpu/intel/haswell/smmrelocate.c
M src/cpu/intel/model_2065x/model_2065x_init.c
M src/cpu/x86/lapic/lapic_cpu_init.c
M src/include/cpu/x86/lapic.h
M src/mainboard/advansus/a785e-i/romstage.c
M src/mainboard/amd/bettong/romstage.c
M src/mainboard/amd/bimini_fam10/romstage.c
M src/mainboard/amd/db-ft3b-lc/romstage.c
M src/mainboard/amd/mahogany_fam10/romstage.c
M src/mainboard/amd/olivehillplus/romstage.c
M src/mainboard/amd/serengeti_cheetah_fam10/romstage.c
M src/mainboard/amd/tilapia_fam10/romstage.c
M src/mainboard/asus/kcma-d8/romstage.c
M src/mainboard/asus/kfsn4-dre/romstage.c
M src/mainboard/asus/kgpe-d16/romstage.c
M src/mainboard/asus/m4a78-em/romstage.c
M src/mainboard/asus/m4a785-m/romstage.c
M src/mainboard/asus/m5a88-v/romstage.c
M src/mainboard/avalue/eax-785e/romstage.c
M src/mainboard/bap/ode_e21XX/romstage.c
M src/mainboard/gigabyte/ma785gm/romstage.c
M src/mainboard/gigabyte/ma785gmt/romstage.c
M src/mainboard/gigabyte/ma78gm/romstage.c
M src/mainboard/hp/dl165_g6_fam10/romstage.c
M src/mainboard/iei/kino-780am2-fam10/romstage.c
M src/mainboard/jetway/pa78vm5/romstage.c
M src/mainboard/msi/ms9652_fam10/romstage.c
M src/mainboard/pcengines/apu2/romstage.c
M src/mainboard/supermicro/h8dmr_fam10/romstage.c
M src/mainboard/supermicro/h8qme_fam10/romstage.c
M src/mainboard/supermicro/h8scm_fam10/romstage.c
M src/mainboard/tyan/s2912_fam10/romstage.c
M src/soc/intel/broadwell/smmrelocate.c
M src/soc/intel/cannonlake/smmrelocate.c
M src/soc/intel/fsp_broadwell_de/smmrelocate.c
M src/soc/intel/icelake/smmrelocate.c
M src/soc/intel/skylake/smmrelocate.c
38 files changed, 37 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/36373/2

Change in coreboot[master]: src: Use '#include <smp/node.h>' when appropriate

[HAOUAS Elyes (Code Review)]

Hello Patrick Rudolph, Piotr Król, Philipp Deppenwiese, build bot (Jenkins), David Guckian, Michał Żygowski,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/36373

to look at the new patch set (#3).

Change subject: src: Use '#include <smp/node.h>' when appropriate
......................................................................

src: Use '#include <smp/node.h>' when appropriate

Change-Id: Icdd6b49751763ef0edd4c57e855cc1d042dc6d4d
Signed-off-by: Elyes HAOUAS 
---
M src/cpu/intel/fsp_model_406dx/model_406dx_init.c
M src/cpu/intel/haswell/smmrelocate.c
M src/cpu/intel/model_2065x/model_2065x_init.c
M src/cpu/x86/lapic/lapic_cpu_init.c
M src/include/cpu/x86/lapic.h
M src/mainboard/advansus/a785e-i/romstage.c
M src/mainboard/amd/bettong/romstage.c
M src/mainboard/amd/bimini_fam10/romstage.c
M src/mainboard/amd/db-ft3b-lc/romstage.c
M src/mainboard/amd/mahogany_fam10/romstage.c
M src/mainboard/amd/olivehillplus/romstage.c
M src/mainboard/amd/serengeti_cheetah_fam10/romstage.c
M src/mainboard/amd/tilapia_fam10/romstage.c
M src/mainboard/asus/kcma-d8/romstage.c
M src/mainboard/asus/kfsn4-dre/romstage.c
M src/mainboard/asus/kgpe-d16/romstage.c
M src/mainboard/asus/m4a78-em/romstage.c
M src/mainboard/asus/m4a785-m/romstage.c
M src/mainboard/asus/m5a88-v/romstage.c
M src/mainboard/avalue/eax-785e/romstage.c
M src/mainboard/bap/ode_e21XX/romstage.c
M src/mainboard/gigabyte/ma785gm/romstage.c
M src/mainboard/gigabyte/ma785gmt/romstage.c
M src/mainboard/gigabyte/ma78gm/romstage.c
M src/mainboard/hp/dl165_g6_fam10/romstage.c
M src/mainboard/iei/kino-780am2-fam10/romstage.c
M src/mainboard/jetway/pa78vm5/romstage.c
M src/mainboard/msi/ms9652_fam10/romstage.c
M src/mainboard/pcengines/apu2/romstage.c
M src/mainboard/supermicro/h8dmr_fam10/romstage.c
M src/mainboard/supermicro/h8qme_fam10/romstage.c
M src/mainboard/supermicro/h8scm_fam10/romstage.c
M src/mainboard/tyan/s2912_fam10/romstage.c
M src/soc/intel/broadwell/smmrelocate.c
M src/soc/intel/cannonlake/smmrelocate.c
M src/soc/intel/fsp_broadwell_de/smmrelocate.c
M src/soc/intel/icelake/smmrelocate.c
M src/soc/intel/skylake/smmrelocate.c
38 files changed, 37 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/36373/3

Change in coreboot[master]: src: Use '#include <smp/node.h>' when appropriate

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36373 )

Change subject: src: Use '#include <smp/node.h>' when appropriate
......................................................................

Patch Set 3: Code-Review+2

Change in coreboot[master]: src: Use '#include <smp/node.h>' when appropriate

[HAOUAS Elyes (Code Review)]

Hello Patrick Rudolph, Piotr Król, Philipp Deppenwiese, build bot (Jenkins), Martin Roth, David Guckian, Michał Żygowski,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/36373

to look at the new patch set (#6).

Change subject: src: Use '#include <smp/node.h>' when appropriate
......................................................................

src: Use '#include <smp/node.h>' when appropriate

Change-Id: Icdd6b49751763ef0edd4c57e855cc1d042dc6d4d
Signed-off-by: Elyes HAOUAS 
---
M src/cpu/intel/haswell/smmrelocate.c
M src/cpu/intel/model_2065x/model_2065x_init.c
M src/cpu/x86/lapic/lapic_cpu_init.c
M src/include/cpu/x86/lapic.h
M src/mainboard/amd/bettong/romstage.c
M src/mainboard/amd/db-ft3b-lc/romstage.c
M src/mainboard/amd/olivehillplus/romstage.c
M src/mainboard/bap/ode_e21XX/romstage.c
M src/mainboard/pcengines/apu2/romstage.c
M src/soc/intel/broadwell/smmrelocate.c
M src/soc/intel/cannonlake/smmrelocate.c
M src/soc/intel/icelake/smmrelocate.c
M src/soc/intel/skylake/smmrelocate.c
D src/soc/intel/tigerlake/smmrelocate.c
14 files changed, 12 insertions(+), 273 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/36373/6

Change in coreboot[master]: src: Use '#include <smp/node.h>' when appropriate

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36373 )

Change subject: src: Use '#include <smp/node.h>' when appropriate
......................................................................

Patch Set 6:

While probably correct, let's put this on hold to avoid some manual rebase. Most of the */romstage.c and */smmrelocate.c files here are in process of rewrite or removal.

Change in coreboot[master]: src: Use '#include <smp/node.h>' when appropriate

[HAOUAS Elyes (Code Review)]

Hello Patrick Rudolph, Piotr Król, Philipp Deppenwiese, build bot (Jenkins), Martin Roth, David Guckian, Michał Żygowski,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/36373

to look at the new patch set (#7).

Change subject: src: Use '#include <smp/node.h>' when appropriate
......................................................................

src: Use '#include <smp/node.h>' when appropriate

Change-Id: Icdd6b49751763ef0edd4c57e855cc1d042dc6d4d
Signed-off-by: Elyes HAOUAS 
---
M src/cpu/intel/haswell/smmrelocate.c
M src/cpu/intel/model_2065x/model_2065x_init.c
M src/cpu/x86/lapic/lapic_cpu_init.c
M src/include/cpu/x86/lapic.h
M src/mainboard/amd/bettong/romstage.c
M src/mainboard/amd/db-ft3b-lc/romstage.c
M src/mainboard/amd/olivehillplus/romstage.c
M src/mainboard/bap/ode_e21XX/romstage.c
M src/mainboard/pcengines/apu2/romstage.c
M src/soc/intel/broadwell/smmrelocate.c
M src/soc/intel/cannonlake/smmrelocate.c
M src/soc/intel/icelake/smmrelocate.c
M src/soc/intel/skylake/smmrelocate.c
13 files changed, 12 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/36373/7

Change in coreboot[master]: src: Use '#include <smp/node.h>' when appropriate

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36373 )

Change subject: src: Use '#include <smp/node.h>' when appropriate
......................................................................

Patch Set 7:

Skip the amd/ bap/ and pcengines/, boot_cpu() will be gone from those.

Change in coreboot[master]: src: Use '#include <smp/node.h>' when appropriate

[HAOUAS Elyes (Code Review)]

Hello Patrick Rudolph, Piotr Król, Philipp Deppenwiese, build bot (Jenkins), Martin Roth, David Guckian, Michał Żygowski,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/36373

to look at the new patch set (#8).

Change subject: src: Use '#include <smp/node.h>' when appropriate
......................................................................

src: Use '#include <smp/node.h>' when appropriate

Change-Id: Icdd6b49751763ef0edd4c57e855cc1d042dc6d4d
Signed-off-by: Elyes HAOUAS 
---
M src/cpu/intel/haswell/smmrelocate.c
M src/cpu/intel/model_2065x/model_2065x_init.c
M src/cpu/x86/lapic/lapic_cpu_init.c
M src/include/cpu/x86/lapic.h
M src/mainboard/amd/bettong/romstage.c
M src/mainboard/amd/db-ft3b-lc/romstage.c
M src/mainboard/amd/olivehillplus/romstage.c
M src/mainboard/bap/ode_e21XX/romstage.c
M src/mainboard/pcengines/apu2/romstage.c
M src/soc/intel/broadwell/smmrelocate.c
M src/soc/intel/cannonlake/smmrelocate.c
M src/soc/intel/icelake/smmrelocate.c
M src/soc/intel/skylake/smmrelocate.c
M src/soc/intel/tigerlake/smmrelocate.c
14 files changed, 13 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/36373/8

Change in coreboot[master]: src: Use '#include <smp/node.h>' when appropriate

[HAOUAS Elyes (Code Review)]

Hello Patrick Rudolph, Piotr Król, Philipp Deppenwiese, build bot (Jenkins), Martin Roth, David Guckian, Michał Żygowski,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/36373

to look at the new patch set (#10).

Change subject: src: Use '#include <smp/node.h>' when appropriate
......................................................................

src: Use '#include <smp/node.h>' when appropriate

Change-Id: Icdd6b49751763ef0edd4c57e855cc1d042dc6d4d
Signed-off-by: Elyes HAOUAS 
---
M src/cpu/intel/haswell/smmrelocate.c
M src/cpu/intel/model_2065x/model_2065x_init.c
M src/cpu/x86/lapic/lapic_cpu_init.c
M src/include/cpu/x86/lapic.h
M src/soc/intel/broadwell/smmrelocate.c
M src/soc/intel/cannonlake/smmrelocate.c
M src/soc/intel/icelake/smmrelocate.c
M src/soc/intel/skylake/smmrelocate.c
M src/soc/intel/tigerlake/smmrelocate.c
9 files changed, 8 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/36373/10

Change in coreboot[master]: src: Use '#include <smp/node.h>' when appropriate

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36373 )

Change subject: src: Use '#include <smp/node.h>' when appropriate
......................................................................

Patch Set 10: Code-Review+2

Change in coreboot[master]: src: Use '#include <smp/node.h>' when appropriate

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36373 )

Change subject: src: Use '#include <smp/node.h>' when appropriate
......................................................................

src: Use '#include <smp/node.h>' when appropriate

Change-Id: Icdd6b49751763ef0edd4c57e855cc1d042dc6d4d
Signed-off-by: Elyes HAOUAS 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/36373
Tested-by: build bot (Jenkins) 
Reviewed-by: Kyösti Mälkki 
---
M src/cpu/intel/haswell/smmrelocate.c
M src/cpu/intel/model_2065x/model_2065x_init.c
M src/cpu/x86/lapic/lapic_cpu_init.c
M src/include/cpu/x86/lapic.h
M src/soc/intel/broadwell/smmrelocate.c
M src/soc/intel/cannonlake/smmrelocate.c
M src/soc/intel/icelake/smmrelocate.c
M src/soc/intel/skylake/smmrelocate.c
M src/soc/intel/tigerlake/smmrelocate.c
9 files changed, 8 insertions(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Kyösti Mälkki: Looks good to me, approved

diff --git a/src/cpu/intel/haswell/smmrelocate.c b/src/cpu/intel/haswell/smmrelocate.c
index 8419746..d259460 100644
--- a/src/cpu/intel/haswell/smmrelocate.c
+++ b/src/cpu/intel/haswell/smmrelocate.c
@@ -27,6 +27,7 @@
 #include <console/console.h>
 #include <northbridge/intel/haswell/haswell.h>
 #include <southbridge/intel/lynxpoint/pch.h>
+#include <smp/node.h>
 #include "haswell.h"

#define MSR_PRMRR_PHYS_BASE 0x1f4
diff --git a/src/cpu/intel/model_2065x/model_2065x_init.c b/src/cpu/intel/model_2065x/model_2065x_init.c
index d7e84ec..a9c28f6 100644
--- a/src/cpu/intel/model_2065x/model_2065x_init.c
+++ b/src/cpu/intel/model_2065x/model_2065x_init.c
@@ -30,6 +30,7 @@
 #include "chip.h"
 #include <cpu/intel/smm_reloc.h>
 #include <cpu/intel/common/common.h>
+#include <smp/node.h>

/*
  * List of supported C-states in this processor
diff --git a/src/cpu/x86/lapic/lapic_cpu_init.c b/src/cpu/x86/lapic/lapic_cpu_init.c
index 48350b3..be825ec 100644
--- a/src/cpu/x86/lapic/lapic_cpu_init.c
+++ b/src/cpu/x86/lapic/lapic_cpu_init.c
@@ -28,6 +28,7 @@
 #include <smp/spinlock.h>
 #include <cpu/cpu.h>
 #include <cpu/intel/speedstep.h>
+#include <smp/node.h>
 #include <stdlib.h>
 #include <thread.h>

diff --git a/src/include/cpu/x86/lapic.h b/src/include/cpu/x86/lapic.h
index 6fd1997..f8081b5 100644
--- a/src/include/cpu/x86/lapic.h
+++ b/src/include/cpu/x86/lapic.h
@@ -4,7 +4,6 @@
 #include <cpu/x86/lapic_def.h>
 #include <cpu/x86/msr.h>
 #include <halt.h>
-#include <smp/node.h>

static __always_inline unsigned long lapic_read(unsigned long reg)
 {
diff --git a/src/soc/intel/broadwell/smmrelocate.c b/src/soc/intel/broadwell/smmrelocate.c
index b5af989..7bf351a 100644
--- a/src/soc/intel/broadwell/smmrelocate.c
+++ b/src/soc/intel/broadwell/smmrelocate.c
@@ -27,6 +27,7 @@
 #include <cpu/intel/em64t101_save_state.h>
 #include <cpu/intel/smm_reloc.h>
 #include <console/console.h>
+#include <smp/node.h>
 #include <soc/cpu.h>
 #include <soc/msr.h>
 #include <soc/pci_devs.h>
diff --git a/src/soc/intel/cannonlake/smmrelocate.c b/src/soc/intel/cannonlake/smmrelocate.c
index 54e2f92..e99a9a2 100644
--- a/src/soc/intel/cannonlake/smmrelocate.c
+++ b/src/soc/intel/cannonlake/smmrelocate.c
@@ -28,6 +28,7 @@
 #include <cpu/intel/em64t101_save_state.h>
 #include <cpu/intel/smm_reloc.h>
 #include <console/console.h>
+#include <smp/node.h>
 #include <soc/cpu.h>
 #include <soc/msr.h>
 #include <soc/pci_devs.h>
diff --git a/src/soc/intel/icelake/smmrelocate.c b/src/soc/intel/icelake/smmrelocate.c
index cc8a5ff..0bedc9e6 100644
--- a/src/soc/intel/icelake/smmrelocate.c
+++ b/src/soc/intel/icelake/smmrelocate.c
@@ -27,6 +27,7 @@
 #include <cpu/intel/em64t101_save_state.h>
 #include <cpu/intel/smm_reloc.h>
 #include <console/console.h>
+#include <smp/node.h>
 #include <soc/cpu.h>
 #include <soc/msr.h>
 #include <soc/pci_devs.h>
diff --git a/src/soc/intel/skylake/smmrelocate.c b/src/soc/intel/skylake/smmrelocate.c
index 65d96ae..62fc7e4 100644
--- a/src/soc/intel/skylake/smmrelocate.c
+++ b/src/soc/intel/skylake/smmrelocate.c
@@ -28,6 +28,7 @@
 #include <cpu/intel/em64t101_save_state.h>
 #include <cpu/intel/smm_reloc.h>
 #include <console/console.h>
+#include <smp/node.h>
 #include <soc/cpu.h>
 #include <soc/msr.h>
 #include <soc/pci_devs.h>
diff --git a/src/soc/intel/tigerlake/smmrelocate.c b/src/soc/intel/tigerlake/smmrelocate.c
index 46f550b..9e21a23 100644
--- a/src/soc/intel/tigerlake/smmrelocate.c
+++ b/src/soc/intel/tigerlake/smmrelocate.c
@@ -27,6 +27,7 @@
 #include <cpu/intel/em64t101_save_state.h>
 #include <cpu/intel/smm_reloc.h>
 #include <console/console.h>
+#include <smp/node.h>
 #include <soc/cpu.h>
 #include <soc/msr.h>
 #include <soc/pci_devs.h>