Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36527 )
Change subject: timestamps: COLLECT_TIMESTAMPS is always optional ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/c/coreboot/+/36527/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36527/3//COMMIT_MSG@14 PS3, Line 14: the use of get_us_since_boot() with COLLECT_TIMESTAMPS=n. Why is it that there is an increase in those conditions?
https://review.coreboot.org/c/coreboot/+/36527/3//COMMIT_MSG@15 PS3, Line 15: We could implement get_us_since_boot() over monotonic timer. Currently monotonic timer is relative to the stage. It's not global and free running. It can't be used for get_us_sinc_boot(). If you nuke all the logic in timer_monotonic_get() from src/cpu/x86/tsc/delay_tsc.c then it will be more free running. But right now the implementation is only giving you microseconds elapsed from the first instance of calling timer_monotonic_get().
https://review.coreboot.org/c/coreboot/+/36527/3/src/mainboard/intel/galileo... File src/mainboard/intel/galileo/Kconfig:
https://review.coreboot.org/c/coreboot/+/36527/3/src/mainboard/intel/galileo... PS3, Line 109: select COLLECT_TIMESTAMPS What happens when someone decides to change the default to 'n' for COLLECT_TIMESTAMPS going by the similar logic that it's only a debugging aid?
-
Aaron Durbin (Code Review)