Change in coreboot[master]: drivers/usb: Add chip driver for VL822 USB hub - coreboot-gerrit

2 May 2022


      Attention is currently required from: Tim Wawrzynczak, Jon Murphy, Karthik Ramasubramanian.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63968 )
Change subject: drivers/usb: Add chip driver for VL822 USB hub
......................................................................
Patch Set 2:
(1 comment)
File src/drivers/usb/vl/acpi_vl822.c:
https://review.coreboot.org/c/coreboot/+/63968/comment/c24c1a15_bdc1f142 
PS2, Line 91: ViaLabs VL822
Nothing about this file looks like it's VL822 specific. It looks like you just need a generic USB hub driver to write the required ACPI nodes. Maybe rename the files to `drivers/usb/hub` or `drivers/usb_hub/acpi`, etc.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/63968
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I11d7ccc42d3dce8e136eb771f120825980e5c027
Gerrit-Change-Number: 63968
Gerrit-PatchSet: 2
Gerrit-Owner: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Jon Murphy jpmurphy@google.com
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Attention: Jon Murphy jpmurphy@google.com
Gerrit-Attention: Karthik Ramasubramanian kramasub@google.com
Gerrit-Comment-Date: Mon, 02 May 2022 21:33:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment