Change in coreboot[master]: device/pci_device.c: Do not complain about disabled devices

[Angel Pons (Code Review)]

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43767 )

Change subject: device/pci_device.c: Do not complain about disabled devices
......................................................................

device/pci_device.c: Do not complain about disabled devices

One would expect disabled devices to not be present. So, don't print
misleading warnings about it, because it only confuses people.

Change-Id: I0f14174a1d460a479dc9f15b63486f4f27b8f67c
Signed-off-by: Angel Pons 
---
M src/device/pci_device.c
1 file changed, 4 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/43767/1

diff --git a/src/device/pci_device.c b/src/device/pci_device.c
index 3623c3b..f3cced9 100644
--- a/src/device/pci_device.c
+++ b/src/device/pci_device.c
@@ -1297,6 +1297,10 @@
    	/* Unlink it from list. */
    	*prev = dev->sibling;

+		/* If disabled in devicetree, do not print any messages. */
+		if (!dev->enabled)
+			continue;
+
    	if (!once++)
    		printk(BIOS_WARNING, "PCI: Leftover static devices:\n");
    	printk(BIOS_WARNING, "%s\n", dev_path(dev));

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43767 )

Change subject: device/pci_device.c: Do not complain about disabled devices
......................................................................

Patch Set 1: Code-Review+2

[Aaron Durbin (Code Review)]

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43767 )

Change subject: device/pci_device.c: Do not complain about disabled devices
......................................................................

Patch Set 1: Code-Review+2

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43767 )

Change subject: device/pci_device.c: Do not complain about disabled devices
......................................................................

Patch Set 1: Code-Review+2

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43767 )

Change subject: device/pci_device.c: Do not complain about disabled devices
......................................................................

Patch Set 1: Code-Review+1

[Angel Pons (Code Review)]

Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43767 )

Change subject: device/pci_device.c: Do not complain about disabled devices
......................................................................

device/pci_device.c: Do not complain about disabled devices

One would expect disabled devices to not be present. So, don't print
misleading warnings about it, because it only confuses people.

Change-Id: I0f14174a1d460a479dc9f15b63486f4f27b8f67c
Signed-off-by: Angel Pons 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/43767
Tested-by: build bot (Jenkins) 
Reviewed-by: Nico Huber 
Reviewed-by: Aaron Durbin 
Reviewed-by: Furquan Shaikh 
Reviewed-by: Kyösti Mälkki 
---
M src/device/pci_device.c
1 file changed, 4 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Kyösti Mälkki: Looks good to me, but someone else must approve
  Nico Huber: Looks good to me, approved
  Aaron Durbin: Looks good to me, approved
  Furquan Shaikh: Looks good to me, approved

diff --git a/src/device/pci_device.c b/src/device/pci_device.c
index 3623c3b..f3cced9 100644
--- a/src/device/pci_device.c
+++ b/src/device/pci_device.c
@@ -1297,6 +1297,10 @@
    	/* Unlink it from list. */
    	*prev = dev->sibling;

+		/* If disabled in devicetree, do not print any messages. */
+		if (!dev->enabled)
+			continue;
+
    	if (!once++)
    		printk(BIOS_WARNING, "PCI: Leftover static devices:\n");
    	printk(BIOS_WARNING, "%s\n", dev_path(dev));