Change in coreboot[master]: driver/usb/acpi: Add power resources for devices on USB ports
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46713 )
Change subject: driver/usb/acpi: Add power resources for devices on USB ports ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46713/2/src/drivers/usb/acpi/chip.h File src/drivers/usb/acpi/chip.h:
https://review.coreboot.org/c/coreboot/+/46713/2/src/drivers/usb/acpi/chip.h... PS2, Line 47: /* Disable reset and enable GPIO export in _CRS */ : bool disable_gpio_export_in_crs;
Or did you mean not to expose when the GPIOs are meant specifically for power resource i.e. […]
Done
https://review.coreboot.org/c/coreboot/+/46713/2/src/drivers/usb/acpi/usb_ac... File src/drivers/usb/acpi/usb_acpi.c:
https://review.coreboot.org/c/coreboot/+/46713/2/src/drivers/usb/acpi/usb_ac... PS2, Line 65: * Should we apply Power Resource only for Internal ports. *
I think it can be left upto the mainboard to decide based on hardware design?
Ack
-
Karthik Ramasubramanian (Code Review)