Attention is currently required from: Kevin Chang, Nick Vaccaro, YH Lin, Zhuohao Lee.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52150 )
Change subject: lillupup: provide additional VBT for lillipup OLED sku
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
This line: https://review.coreboot.org/plugins/gitiles/coreboot/+/refs/heads/master/src...
should be changed in this patchset to be just:
```
ramstage-y += variant.c
```
along with changing get_wifi_sar_cbfs_filename to:
```
const char *get_wifi_sar_cbfs_filename(void)
{
if (CONFIG(FW_CONFIG)) {
if (fw_config_probe(FW_CONFIG(WIFI_SAR_ID, WIFI_SAR_ID_0)))
return "wifi_sar_0.hex";
else if (fw_config_probe(FW_CONFIG(WIFI_SAR_ID, WIFI_SAR_ID_1)))
return "wifi_sar_1.hex";
}
return WIFI_SAR_CBFS_DEFAULT_FILENAME;
}
```
because variant.c doesn't always depend on fw_config anymore
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52150
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I576297b8296def3c37a01ae0223fa332aa9f02b1
Gerrit-Change-Number: 52150
Gerrit-PatchSet: 2
Gerrit-Owner: Kevin Chang
kevin.chang@lcfc.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: YH Lin
yueherngl@chromium.org
Gerrit-Reviewer: YH Lin
yueherngl@google.com
Gerrit-Reviewer: Zhuohao Lee
zhuohao@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jerry2 Huang
jerry2.huang@lcfc.corp-partner.google.com
Gerrit-CC: Lauren Ting
lauren.ting@lcfc.corp-partner.google.com
Gerrit-Attention: Kevin Chang
kevin.chang@lcfc.corp-partner.google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: YH Lin
yueherngl@chromium.org
Gerrit-Attention: Zhuohao Lee
zhuohao@chromium.org
Gerrit-Comment-Date: Wed, 07 Apr 2021 19:09:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment