[M] Change in coreboot[master]: soc/amd/common/psp_verstage: Map/unmap boot device on need basis
Attention is currently required from: Jason Glenesk, Raul Rangel, Matt DeVillier, Martin Roth, Fred Reitberger, Felix Held.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74606 )
Change subject: soc/amd/common/psp_verstage: Map/unmap boot device on need basis ......................................................................
Patch Set 1:
(3 comments)
File src/soc/amd/common/psp_verstage/boot_dev.c:
https://review.coreboot.org/c/coreboot/+/74606/comment/1b7df134_c57a96d0 PS1, Line 22: svc_map_spi_rom
I expect SVC call to not touch mapping on failure. […]
Confirmed that on failure, mapping is untouched. So mapping should be NULL on failure.
https://review.coreboot.org/c/coreboot/+/74606/comment/6964acce_c12ae3e7 PS1, Line 22: size
Not that I am aware of. I can check with PSP team.
Confirmed through the bug, there is no restriction on size of region to be mapped. There is no alignment restriction on size and offset.
File src/soc/amd/common/psp_verstage/fch.c:
https://review.coreboot.org/c/coreboot/+/74606/comment/20f785a9_e012018d PS1, Line 100: SpiBiosSmnBase
Atleast as per the command structure defined in bl_syscall_public.h - https://chromium.googlesource. […]
Done
-
Karthik Ramasubramanian (Code Review)