Change in ...coreboot[master]: util/lint: check correctness of Change-Id line

List overview All Threads
Download

newer

older

Change in ...coreboot[master]:...

Change in coreboot[master]:...

Idwer Vollering (Code Review)

29 Jun 2019 29 Jun '19

5:38 p.m.

Idwer Vollering has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33884

Change subject: util/lint: check correctness of Change-Id line ......................................................................

util/lint: check correctness of Change-Id line

Change-Id: I67b9f134500bb596ae5790b68fe9f27e2fa2cfb4 Signed-off-by: Idwer Vollering vidwer@gmail.com --- A util/lint/lint-extended-024-change-id 1 file changed, 10 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/33884/1

diff --git a/util/lint/lint-extended-024-change-id b/util/lint/lint-extended-024-change-id new file mode 100755 index 0000000..1989ed4 --- /dev/null +++ b/util/lint/lint-extended-024-change-id @@ -0,0 +1,10 @@ +#!/bin/sh +if [ "$(git log -n 1 | grep -c '[[:space:]]+Change-Id: ')" -lt 1 ] +then + echo "Change-Id line is missing"; +fi + +if [ "$(git log -n 1 | grep -c '[[:space:]]+Change-Id: ')" -gt 1 ] +then + echo "Found more than one Change-Id line"; +fi

Attachments:

attachment.htm (text/html — 2.7 KB)

Show replies by date

Idwer Vollering (Code Review)

29 Jun 29 Jun

5:44 p.m.

New subject: Change in ...coreboot[master]: util/lint: check for Change-Id line presence and duplicates

Hello Paul Menzel, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33884

to look at the new patch set (#2).

Change subject: util/lint: check for Change-Id line presence and duplicates ......................................................................

util/lint: check for Change-Id line presence and duplicates

Change-Id: I67b9f134500bb596ae5790b68fe9f27e2fa2cfb4 Signed-off-by: Idwer Vollering vidwer@gmail.com --- A util/lint/lint-extended-024-change-id 1 file changed, 10 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/33884/2

Idwer Vollering (Code Review)

7:12 p.m.

New subject: Change in ...coreboot[master]: util/lint: check for Change-Id line presence and duplicates

Idwer Vollering has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33884 )

Change subject: util/lint: check for Change-Id line presence and duplicates ......................................................................

Patch Set 2:

I wrote this to fail tests, see https://review.coreboot.org/c/coreboot/+/30987 Should it end up in checkpatch.pl?

Patrick Georgi (Code Review)

17 Jul 17 Jul

9:01 p.m.

New subject: Change in coreboot[master]: util/lint: check for Change-Id line presence and duplicates

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33884 )

Change subject: util/lint: check for Change-Id line presence and duplicates ......................................................................

Patch Set 2:

...

Patch Set 2:

I wrote this to fail tests, see https://review.coreboot.org/c/coreboot/+/30987 Should it end up in checkpatch.pl?

You mean to fail tests on jenkins? That should work since what-jenkins-does calls lint with --junit, which _should_ emit test results. I think something is broken there.

No need to touch checkpatch though.

-- To view, visit https://review.coreboot.org/c/coreboot/+/33884 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I67b9f134500bb596ae5790b68fe9f27e2fa2cfb4 Gerrit-Change-Number: 33884 Gerrit-PatchSet: 2 Gerrit-Owner: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 17 Jul 2019 19:01:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Patrick Georgi (Code Review)

9:02 p.m.

New subject: Change in coreboot[master]: util/lint: check for Change-Id line presence and duplicates

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33884 )

Change subject: util/lint: check for Change-Id line presence and duplicates ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/33884/2/util/lint/lint-extended-024... File util/lint/lint-extended-024-change-id:

https://review.coreboot.org/c/coreboot/+/33884/2/util/lint/lint-extended-024... PS2, Line 2: $(git log -n 1 | grep -c '[[:space:]]+Change-Id: ') I guess it doesn't matter time-wise, but why not store the result in a variable instead of executing twice?

-- To view, visit https://review.coreboot.org/c/coreboot/+/33884 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I67b9f134500bb596ae5790b68fe9f27e2fa2cfb4 Gerrit-Change-Number: 33884 Gerrit-PatchSet: 2 Gerrit-Owner: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 17 Jul 2019 19:02:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Angel Pons (Code Review)

9:02 p.m.

New subject: Change in coreboot[master]: util/lint: check for Change-Id line presence and duplicates

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33884 )

Change subject: util/lint: check for Change-Id line presence and duplicates ......................................................................

Patch Set 2: Code-Review+1

Thanks for this patch!

Looks good, but haven't taken a proper look at it yet.

-- To view, visit https://review.coreboot.org/c/coreboot/+/33884 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I67b9f134500bb596ae5790b68fe9f27e2fa2cfb4 Gerrit-Change-Number: 33884 Gerrit-PatchSet: 2 Gerrit-Owner: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 17 Jul 2019 19:02:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Paul Menzel (Code Review)

18 Jul 18 Jul

2:55 p.m.

New subject: Change in coreboot[master]: util/lint: check for Change-Id line presence and duplicates

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33884 )

Change subject: util/lint: check for Change-Id line presence and duplicates ......................................................................

Patch Set 2:

Just to be sure, for developers having linting enabled, this will be run after the commit message has been written and updated by the “Change-Id adding hook”?

-- To view, visit https://review.coreboot.org/c/coreboot/+/33884 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I67b9f134500bb596ae5790b68fe9f27e2fa2cfb4 Gerrit-Change-Number: 33884 Gerrit-PatchSet: 2 Gerrit-Owner: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 18 Jul 2019 12:55:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Idwer Vollering (Code Review)

12 Dec 12 Dec

12:58 p.m.

New subject: Change in coreboot[master]: util/lint: check for Change-Id line presence and duplicates

Hello Angel Pons, Paul Menzel, build bot (Jenkins), Nico Huber, Patrick Georgi,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33884

to look at the new patch set (#3).

Change subject: util/lint: check for Change-Id line presence and duplicates ......................................................................

util/lint: check for Change-Id line presence and duplicates

Change-Id: I67b9f134500bb596ae5790b68fe9f27e2fa2cfb4 Signed-off-by: Idwer Vollering vidwer@gmail.com --- A util/lint/lint-extended-024-change-id 1 file changed, 12 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/33884/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/33884 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I67b9f134500bb596ae5790b68fe9f27e2fa2cfb4 Gerrit-Change-Number: 33884 Gerrit-PatchSet: 3 Gerrit-Owner: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Idwer Vollering (Code Review)

1 p.m.

New subject: Change in coreboot[master]: util/lint: check for Change-Id line presence and duplicates

Idwer Vollering has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33884 )

Change subject: util/lint: check for Change-Id line presence and duplicates ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/33884/2/util/lint/lint-extended-024... File util/lint/lint-extended-024-change-id:

https://review.coreboot.org/c/coreboot/+/33884/2/util/lint/lint-extended-024... PS2, Line 2: $(git log -n 1 | grep -c '[[:space:]]+Change-Id: ')

...

I guess it doesn't matter time-wise, but why not store the result in a variable instead of executing […]

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/33884 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I67b9f134500bb596ae5790b68fe9f27e2fa2cfb4 Gerrit-Change-Number: 33884 Gerrit-PatchSet: 3 Gerrit-Owner: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 12 Dec 2019 12:00:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Georgi pgeorgi@google.com Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

1:06 p.m.

New subject: Change in coreboot[master]: util/lint: check for Change-Id line presence and duplicates

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33884 )

Change subject: util/lint: check for Change-Id line presence and duplicates ......................................................................

Patch Set 3: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/33884 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I67b9f134500bb596ae5790b68fe9f27e2fa2cfb4 Gerrit-Change-Number: 33884 Gerrit-PatchSet: 3 Gerrit-Owner: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 12 Dec 2019 12:06:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

1:13 p.m.

New subject: Change in coreboot[master]: util/lint: check for Change-Id line presence and duplicates

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33884 )

Change subject: util/lint: check for Change-Id line presence and duplicates ......................................................................

Patch Set 3: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/33884 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I67b9f134500bb596ae5790b68fe9f27e2fa2cfb4 Gerrit-Change-Number: 33884 Gerrit-PatchSet: 3 Gerrit-Owner: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 12 Dec 2019 12:13:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Angel Pons (Code Review)

1:14 p.m.

New subject: Change in coreboot[master]: util/lint: check for Change-Id line presence and duplicates

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33884 )

Change subject: util/lint: check for Change-Id line presence and duplicates ......................................................................

Patch Set 3: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/33884 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I67b9f134500bb596ae5790b68fe9f27e2fa2cfb4 Gerrit-Change-Number: 33884 Gerrit-PatchSet: 3 Gerrit-Owner: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 12 Dec 2019 12:14:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Paul Menzel (Code Review)

3:35 p.m.

New subject: Change in coreboot[master]: util/lint: check for Change-Id line presence and duplicates

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33884 )

Change subject: util/lint: check for Change-Id line presence and duplicates ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/33884/3/util/lint/lint-extended-024... File util/lint/lint-extended-024-change-id:

https://review.coreboot.org/c/coreboot/+/33884/3/util/lint/lint-extended-024... PS3, Line 2: CHANGE_ID_LINECOUNT=$(git log -n 1 | grep -c '[[:space:]]+Change-Id: ') Original-Change-Id is not matched, right?

-- To view, visit https://review.coreboot.org/c/coreboot/+/33884 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I67b9f134500bb596ae5790b68fe9f27e2fa2cfb4 Gerrit-Change-Number: 33884 Gerrit-PatchSet: 3 Gerrit-Owner: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 12 Dec 2019 14:35:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Nico Huber (Code Review)

3:50 p.m.

New subject: Change in coreboot[master]: util/lint: check for Change-Id line presence and duplicates

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33884 )

Change subject: util/lint: check for Change-Id line presence and duplicates ......................................................................

Patch Set 3:

(1 comment)

...

Just to be sure, for developers having linting enabled, this will be run after the commit message has been written and updated by the “Change-Id adding hook”?

I was also wondering when it is supposed to be run?

https://review.coreboot.org/c/coreboot/+/33884/3/util/lint/lint-extended-024... File util/lint/lint-extended-024-change-id:

https://review.coreboot.org/c/coreboot/+/33884/3/util/lint/lint-extended-024... PS3, Line 2: CHANGE_ID_LINECOUNT=$(git log -n 1 | grep -c '[[:space:]]+Change-Id: ')

...

Original-Change-Id is not matched, right?

Right.

-- To view, visit https://review.coreboot.org/c/coreboot/+/33884 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I67b9f134500bb596ae5790b68fe9f27e2fa2cfb4 Gerrit-Change-Number: 33884 Gerrit-PatchSet: 3 Gerrit-Owner: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 12 Dec 2019 14:50:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Patrick Georgi (Code Review)

4:18 p.m.

New subject: Change in coreboot[master]: util/lint: check for Change-Id line presence and duplicates

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33884 )

Change subject: util/lint: check for Change-Id line presence and duplicates ......................................................................

Patch Set 3: -Code-Review

I double checked, and our lint scripts are executed in the pre-commit hook (but only the "stable" ones), which is run before the commit-msg hook that adds Change-Id.

So what's the intended behavior for this?

-- To view, visit https://review.coreboot.org/c/coreboot/+/33884 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I67b9f134500bb596ae5790b68fe9f27e2fa2cfb4 Gerrit-Change-Number: 33884 Gerrit-PatchSet: 3 Gerrit-Owner: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 12 Dec 2019 15:18:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Idwer Vollering (Code Review)

4:57 p.m.

New subject: Change in coreboot[master]: util/lint: check for Change-Id line presence and duplicates

Idwer Vollering has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33884 )

Change subject: util/lint: check for Change-Id line presence and duplicates ......................................................................

Patch Set 3:

...

Patch Set 3: -Code-Review

I double checked, and our lint scripts are executed in the pre-commit hook (but only the "stable" ones), which is run before the commit-msg hook that adds Change-Id.

So what's the intended behavior for this?

Meaning the file should be renamed (to lint-stable-024-change-id), in order to be run from jenkins?

-- To view, visit https://review.coreboot.org/c/coreboot/+/33884 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I67b9f134500bb596ae5790b68fe9f27e2fa2cfb4 Gerrit-Change-Number: 33884 Gerrit-PatchSet: 3 Gerrit-Owner: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 12 Dec 2019 15:57:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Patrick Georgi (Code Review)

5:07 p.m.

New subject: Change in coreboot[master]: util/lint: check for Change-Id line presence and duplicates

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33884 )

Change subject: util/lint: check for Change-Id line presence and duplicates ......................................................................

Patch Set 3: Code-Review+1

...

Patch Set 3:

...
Patch Set 3: -Code-Review

I double checked, and our lint scripts are executed in the pre-commit hook (but only the "stable" ones), which is run before the commit-msg hook that adds Change-Id.

So what's the intended behavior for this?

Meaning the file should be renamed (to lint-stable-024-change-id), in order to be run from jenkins?

No, jenkins runs both stable and extended (see util/testing/Makefile.inc:93) while pre-commit only runs stable (where this would break: Change-Id isn't added yet). So this is fine.

Please state the intent that this is for Jenkins' sanity tests in the commit message, because it appears to me that folks were wondering how this affects "git commit".

-- To view, visit https://review.coreboot.org/c/coreboot/+/33884 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I67b9f134500bb596ae5790b68fe9f27e2fa2cfb4 Gerrit-Change-Number: 33884 Gerrit-PatchSet: 3 Gerrit-Owner: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 12 Dec 2019 16:07:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Idwer Vollering (Code Review)

6:13 p.m.

New subject: Change in coreboot[master]: util/lint: check for Change-Id line presence and duplicates

Hello HAOUAS Elyes, Angel Pons, Paul Menzel, build bot (Jenkins), Nico Huber, Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33884

to look at the new patch set (#4).

Change subject: util/lint: check for Change-Id line presence and duplicates ......................................................................

util/lint: check for Change-Id line presence and duplicates

This check should run during pre-commit time (before pushing).

Change-Id: I67b9f134500bb596ae5790b68fe9f27e2fa2cfb4 Signed-off-by: Idwer Vollering vidwer@gmail.com --- A util/lint/lint-stable-024-change-id 1 file changed, 12 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/33884/4

-- To view, visit https://review.coreboot.org/c/coreboot/+/33884 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I67b9f134500bb596ae5790b68fe9f27e2fa2cfb4 Gerrit-Change-Number: 33884 Gerrit-PatchSet: 4 Gerrit-Owner: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Martin L Roth (Code Review)

7 Aug 7 Aug

10:45 p.m.

New subject: [S] Change in coreboot[master]: util/lint: check for Change-Id line presence and duplicates

Martin L Roth has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/33884?usp=email )

Change subject: util/lint: check for Change-Id line presence and duplicates ......................................................................

Abandoned

This patch has not been touched in over 12 months. Anyone who wants to take over work on this patch, please feel free to restore it and do any work needed to get it merged. If you create a new patch based on this work, please credit the original author.

-- To view, visit https://review.coreboot.org/c/coreboot/+/33884?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I67b9f134500bb596ae5790b68fe9f27e2fa2cfb4 Gerrit-Change-Number: 33884 Gerrit-PatchSet: 4 Gerrit-Owner: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Martin L Roth gaumless@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Paul Menzel paulepanter@mailbox.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: abandon

473

days inactive

1973

days old

coreboot-gerrit@coreboot.org

18 comments

7 participants

tags (0)

participants (7)

Angel Pons (Code Review)
HAOUAS Elyes (Code Review)
Idwer Vollering (Code Review)
Martin L Roth (Code Review)
Nico Huber (Code Review)
Patrick Georgi (Code Review)
Paul Menzel (Code Review)