Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37923 )
Change subject: mb/google/octopus/variants/garg: update new SKU ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37923/1/src/mainboard/google/octopu... File src/mainboard/google/octopus/variants/garg/gpio.c:
https://review.coreboot.org/c/coreboot/+/37923/1/src/mainboard/google/octopu... PS1, Line 30: SKU_38_2A2C_360_TS_no_stylues = 38,
For naming convention, it looks to me we need capital letters here.
Done
https://review.coreboot.org/c/coreboot/+/37923/1/src/mainboard/google/octopu... PS1, Line 31: };
Could we move this enum definition to variant/sku.h? So it can be included by gpio.c and variant. […]
Done
-
Kevin Chiu (Code Review)