Attention is currently required from: Felix Held.
Martin Roth has posted comments on this change by Felix Held. ( https://review.coreboot.org/c/coreboot/+/85008?usp=email )
Change subject: drivers/spi/spi_flash_sfdp: add SFDP support to get RPMC parameters ......................................................................
Patch Set 3: Code-Review+2
(3 comments)
Patchset:
PS3: Everything looks good. Some nits, but nothing to stop the merge. Change them or close the comments - Just wanted to bring them to your attention.
File src/drivers/spi/spi_flash_sfdp.c:
https://review.coreboot.org/c/coreboot/+/85008/comment/5ac3a078_237aca3e?usp... : PS3, Line 202: #define Why not put this in a header file? Sure, it may only be used here, but it clutters the C code IMO.
https://review.coreboot.org/c/coreboot/+/85008/comment/7074f826_dade23b4?usp... : PS3, Line 250: multiplicator Multiplier?
https://www.merriam-webster.com/dictionary/multiplicator