Attention is currently required from: Bill XIE, Patrick Rudolph, Christian Walter, Julius Werner, Kyösti Mälkki.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52601 )
Change subject: option: Add API for mainboard provided options
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
I think this is not a bad idea in general, but it doesn't seem like
what is needed in the follow up. If the board isn't using the CMOS
option table (I've not found any cmos.layout), it would not need
arbitration between the two option backends. Instead we could have
a single active backend (decided at compile time) and that it is
called is simply decided by what files are included into the build.
Just a thought, it wouldn't need this if (CONFIG(X)) call x, else if...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52601
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic5bbb5b3353d862c5533f90ced4824eec27ca3b9
Gerrit-Change-Number: 52601
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Bill XIE
persmule@hardenedlinux.org
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Bill XIE
persmule@hardenedlinux.org
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Sat, 01 May 2021 15:14:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment