Attention is currently required from: Patrick Rudolph, Simon Chou, TimLiu-SMCI, Johnny Lin, Christian Walter, Arthur Heymans, Jian-Ming Wang, Shuming Chu (Shuming).
Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71967 )
Change subject: soc/intel/xeon_sp/spr: add ACPI code
......................................................................
Patch Set 13:
(1 comment)
File src/soc/intel/xeon_sp/spr/romstage.c:
https://review.coreboot.org/c/coreboot/+/71967/comment/5e7a48fd_b043d389
PS2, Line 177: 0x3F8;
SerialIoUartDebugIoBase in FSPM_UPD is used to control the debug message from Intel FSP. […]
I think:
* Instead of hardcoding, it should be taken from CONFIG_TTYS0_BASE.
* It should be set in mainboard code, instead of SoC code.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/71967
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic2a9be0222e122ae087b9cc8e1859d257e3411d6
Gerrit-Change-Number: 71967
Gerrit-PatchSet: 13
Gerrit-Owner: Simon Chou
simonchou@supermicro.com.tw
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Jian-Ming Wang
jianmingW@supermicro.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: TimLiu-SMCI
timliu@supermicro.com.tw
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Elyes Haouas
ehaouas@noos.fr
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-CC: Shuming Chu (Shuming)
s1218944@gmail.com
Gerrit-CC: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Simon Chou
simonchou@supermicro.com.tw
Gerrit-Attention: TimLiu-SMCI
timliu@supermicro.com.tw
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Jian-Ming Wang
jianmingW@supermicro.com
Gerrit-Attention: Shuming Chu (Shuming)
s1218944@gmail.com
Gerrit-Comment-Date: Sun, 05 Feb 2023 04:59:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jian-Ming Wang
jianmingW@supermicro.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment