build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57642 )
Change subject: mb/google/trogdor: Add mipi panel for wormdingler ......................................................................
Patch Set 1:
(25 comments)
File src/drivers/mipi/panel-BOE_TV110C9M_LL0.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128119): https://review.coreboot.org/c/coreboot/+/57642/comment/1bf10eb4_4d619a17 PS1, Line 36: PANEL_DCS(0xB0, 0x00, 0x08, 0x00, 0x23, 0x00, 0x4D, 0x00, \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128119): https://review.coreboot.org/c/coreboot/+/57642/comment/f040ed44_558fe534 PS1, Line 38: PANEL_DCS(0xB1, 0x00, 0xDA, 0x01, 0x13, 0x01, 0x3C, 0x01, \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128119): https://review.coreboot.org/c/coreboot/+/57642/comment/00527f5b_1c352771 PS1, Line 40: PANEL_DCS(0xB2, 0x02, 0x67, 0x02, 0xA6, 0x02, 0xD1, 0x03, \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128119): https://review.coreboot.org/c/coreboot/+/57642/comment/19aac674_731b957e PS1, Line 42: PANEL_DCS(0xB3, 0x03, 0x8E, 0x03, 0xA2, 0x03, 0xB7, 0x03, \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128119): https://review.coreboot.org/c/coreboot/+/57642/comment/48f8658e_2b083554 PS1, Line 44: PANEL_DCS(0xB4, 0x00, 0x08, 0x00, 0x23, 0x00, 0x4D, 0x00, \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128119): https://review.coreboot.org/c/coreboot/+/57642/comment/c62095ac_9d9b129e PS1, Line 46: PANEL_DCS(0xB5, 0x00, 0xDA, 0x01, 0x13, 0x01, 0x3C, 0x01, \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128119): https://review.coreboot.org/c/coreboot/+/57642/comment/42de397a_d0bf67dc PS1, Line 48: PANEL_DCS(0xB6, 0x02, 0x67, 0x02, 0xA6, 0x02, 0xD1, 0x03, \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128119): https://review.coreboot.org/c/coreboot/+/57642/comment/b2d5a56a_2d2a3e9b PS1, Line 50: PANEL_DCS(0xB7, 0x03, 0x8E, 0x03, 0xA2, 0x03, 0xB7, 0x03, \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128119): https://review.coreboot.org/c/coreboot/+/57642/comment/388cc133_a7d6b697 PS1, Line 52: PANEL_DCS(0xB8, 0x00, 0x08, 0x00, 0x23, 0x00, 0x4D, 0x00, \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128119): https://review.coreboot.org/c/coreboot/+/57642/comment/a234878b_5b6c6ef5 PS1, Line 54: PANEL_DCS(0xB9, 0x00, 0xDA, 0x01, 0x13, 0x01, 0x3C, 0x01, \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128119): https://review.coreboot.org/c/coreboot/+/57642/comment/275cec0e_2e831a53 PS1, Line 56: PANEL_DCS(0xBA, 0x02, 0x67, 0x02, 0xA6, 0x02, 0xD1, 0x03, \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128119): https://review.coreboot.org/c/coreboot/+/57642/comment/026d9849_c15412e2 PS1, Line 58: PANEL_DCS(0xBB, 0x03, 0x8E, 0x03, 0xA2, 0x03, 0xB7, 0x03, \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128119): https://review.coreboot.org/c/coreboot/+/57642/comment/8610fa99_c909e448 PS1, Line 62: PANEL_DCS(0xB0, 0x00, 0x00, 0x00, 0x1B, 0x00, 0x45, 0x00, \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128119): https://review.coreboot.org/c/coreboot/+/57642/comment/e7f3a24a_04a06090 PS1, Line 64: PANEL_DCS(0xB1, 0x00, 0xD2, 0x01, 0x0B, 0x01, 0x34, 0x01, \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128119): https://review.coreboot.org/c/coreboot/+/57642/comment/83b181f7_fd52830a PS1, Line 66: PANEL_DCS(0xB2, 0x02, 0x5F, 0x02, 0x9E, 0x02, 0xC9, 0x03, \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128119): https://review.coreboot.org/c/coreboot/+/57642/comment/9ec91eaf_41b76604 PS1, Line 68: PANEL_DCS(0xB3, 0x03, 0x86, 0x03, 0x9A, 0x03, 0xAF, 0x03, \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128119): https://review.coreboot.org/c/coreboot/+/57642/comment/6e74bd43_55c53af7 PS1, Line 70: PANEL_DCS(0xB4, 0x00, 0x00, 0x00, 0x1B, 0x00, 0x45, 0x00, \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128119): https://review.coreboot.org/c/coreboot/+/57642/comment/0937d2c3_6373fb6f PS1, Line 72: PANEL_DCS(0xB5, 0x00, 0xD2, 0x01, 0x0B, 0x01, 0x34, 0x01, \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128119): https://review.coreboot.org/c/coreboot/+/57642/comment/575eb244_a299bf1c PS1, Line 74: PANEL_DCS(0xB6, 0x02, 0x5F, 0x02, 0x9E, 0x02, 0xC9, 0x03, \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128119): https://review.coreboot.org/c/coreboot/+/57642/comment/57f8f4f1_c43084a3 PS1, Line 76: PANEL_DCS(0xB7, 0x03, 0x86, 0x03, 0x9A, 0x03, 0xAF, 0x03, \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128119): https://review.coreboot.org/c/coreboot/+/57642/comment/bd72a0e5_b3613aa6 PS1, Line 78: PANEL_DCS(0xB8, 0x00, 0x00, 0x00, 0x1B, 0x00, 0x45, 0x00, \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128119): https://review.coreboot.org/c/coreboot/+/57642/comment/adc53514_5146ad77 PS1, Line 80: PANEL_DCS(0xB9, 0x00, 0xD2, 0x01, 0x0B, 0x01, 0x34, 0x01, \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128119): https://review.coreboot.org/c/coreboot/+/57642/comment/2e5d1988_39b00c79 PS1, Line 82: PANEL_DCS(0xBA, 0x02, 0x5F, 0x02, 0x9E, 0x02, 0xC9, 0x03, \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128119): https://review.coreboot.org/c/coreboot/+/57642/comment/e4ca9174_e561d2f2 PS1, Line 84: PANEL_DCS(0xBB, 0x03, 0x86, 0x03, 0x9A, 0x03, 0xAF, 0x03, \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-128119): https://review.coreboot.org/c/coreboot/+/57642/comment/0aa4f2eb_d1e2cbcc PS1, Line 166: PANEL_DCS(0xB6, 0x05, 0x00, 0x05, 0x00, 0x00, 0x00, 0x00, \ Avoid unnecessary line continuations
-
build bot (Jenkins) (Code Review)