Attention is currently required from: Arthur Heymans, Raul Rangel, Nico Huber, Martin Roth, Tim Wawrzynczak, Rob Barnes, Karthik Ramasubramanian.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62355 )
Change subject: cpu/x86/smm,lib/cbmem_console: Enable CBMEMC when using DEBUG_SMI
......................................................................
Patch Set 2:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62355/comment/23047253_d75242cd
PS2, Line 24: and call that from smm_module_handler.
Maybe a nicer way would be to define an smm_get_cbmemc_buffer(void *buffer_out, size_t *size_out) function that the cbmemc_init() can call?
File src/cpu/x86/smm/smm_module_handler.c:
https://review.coreboot.org/c/coreboot/+/62355/comment/0a5e17fb_0b5d224b
PS2, Line 17: size_t cbmemc_size;
Since these are global symbols, please namespace them a bit better (e.g. smm_cbmemc_buffer/smm_cbmemc_size or something like that).
File src/lib/cbmem_console.c:
https://review.coreboot.org/c/coreboot/+/62355/comment/0e28d461_e1e46b7a
PS2, Line 90: extern size_t cbmemc_size;
These should probably go in some SMM-specific header and then be included here.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62355
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia1e310a12ca2f54210ccfaee58807cb808cfff79
Gerrit-Change-Number: 62355
Gerrit-PatchSet: 2
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Rob Barnes
robbarnes@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Wed, 02 Mar 2022 04:12:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment