Attention is currently required from: Hung-Te Lin, Vince Liu, Wentao Qin, Yidi Lin.
Yu-Ping Wu has posted comments on this change by Vince Liu. ( https://review.coreboot.org/c/coreboot/+/87358?usp=email )
Change subject: mb/google/skywalker: Enable ChromeOS EC
......................................................................
Patch Set 1: Code-Review+1
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/87358/comment/183e033e_e8e15c61?usp... :
PS1, Line 11: Chrome
ChromeOS
File src/mainboard/google/skywalker/Kconfig:
https://review.coreboot.org/c/coreboot/+/87358/comment/de27ef98_6f30205d?usp... :
PS1, Line 42: default 0x0
a blank line below
File src/mainboard/google/skywalker/chromeos.c:
https://review.coreboot.org/c/coreboot/+/87358/comment/9f3e8dba_0ec28dd3?usp... :
PS1, Line 13: gpio_output(GPIO_XHCI_INIT_DONE, 0);
This seems unrelated to EC. Please create a separate patch for this.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/87358?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id3d53dfa8e1fdee5f04f01197592d31fee146299
Gerrit-Change-Number: 87358
Gerrit-PatchSet: 1
Gerrit-Owner: Vince Liu
vince-wl.liu@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Wentao Qin
qinwentao@huaqin.corp-partner.google.com
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Vince Liu
vince-wl.liu@mediatek.com
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Attention: Wentao Qin
qinwentao@huaqin.corp-partner.google.com
Gerrit-Comment-Date: Mon, 21 Apr 2025 08:00:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes