Attention is currently required from: Hung-Te Lin, Paul Menzel, Yidi Lin, Yu-Ping Wu.
Sheng-Liang Pan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75563?usp=email )
Change subject: mb/google/kukui: Change Juniper/Willow RAM table offset to 0x30
......................................................................
Patch Set 4: Code-Review+1
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/75563/comment/84ca1dfd_b0970b88 :
PS3, Line 7: change
Change
Done
https://review.coreboot.org/c/coreboot/+/75563/comment/fda28676_d8213814 :
PS3, Line 9: leverage same RAMID
reuse the RAM ID in
Done
https://review.coreboot.org/c/coreboot/+/75563/comment/47a27790_798024d0 :
PS3, Line 9: memory source
DRAM module
Done
https://review.coreboot.org/c/coreboot/+/75563/comment/4c21892b_090f7d1d :
PS3, Line 10: default as
offset to
Done
https://review.coreboot.org/c/coreboot/+/75563/comment/aef7b609_064dc842 :
PS3, Line 11: for further memory 2nd source.
for introducing more DRAM modules.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75563?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I92740275dcc27061a94b7db7ce095655c0bd7cf5
Gerrit-Change-Number: 75563
Gerrit-PatchSet: 4
Gerrit-Owner: Sheng-Liang Pan
sheng-liang.pan@quanta.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Sheng-Liang Pan
sheng-liang.pan@quanta.corp-partner.google.com
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Mon, 05 Jun 2023 01:12:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Yidi Lin
yidilin@google.com
Gerrit-MessageType: comment