Change in coreboot[master]: SMBIOS (Type 17): Update the string for Intel persistent memory

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35895 )

Change subject: SMBIOS (Type 17): Update the string for Intel persistent memory
......................................................................

SMBIOS (Type 17): Update the string for Intel persistent memory

Change-Id: I0cd49ffd05bba4ea29550659ac56ea991b697592
Signed-off-by: Elyes HAOUAS 
---
M src/include/smbios.h
1 file changed, 7 insertions(+), 7 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/35895/1

diff --git a/src/include/smbios.h b/src/include/smbios.h
index eb947dc..94b4208 100644
--- a/src/include/smbios.h
+++ b/src/include/smbios.h
@@ -97,13 +97,13 @@
 #define MEMORY_TYPE_DETAIL_UNBUFFERED		(1 << 14)
 #define MEMORY_TYPE_DETAIL_LRDIMM		(1 << 15)

-#define MEMORY_TECHNOLOGY_OTHER			0x01
-#define MEMORY_TECHNOLOGY_UNKNOWN		0x02
-#define MEMORY_TECHNOLOGY_DRAM			0x03
-#define MEMORY_TECHNOLOGY_NVDIMM_N		0x04
-#define MEMORY_TECHNOLOGY_NVDIMM_F		0x05
-#define MEMORY_TECHNOLOGY_NVDIMM_P		0x06
-#define MEMORY_TECHNOLOGY_INTEL_PERSISTENT	0x07
+#define MEMORY_TECHNOLOGY_OTHER				0x01
+#define MEMORY_TECHNOLOGY_UNKNOWN			0x02
+#define MEMORY_TECHNOLOGY_DRAM				0x03
+#define MEMORY_TECHNOLOGY_NVDIMM_N			0x04
+#define MEMORY_TECHNOLOGY_NVDIMM_F			0x05
+#define MEMORY_TECHNOLOGY_NVDIMM_P			0x06
+#define MEMORY_TECHNOLOGY_INTEL_OPTANE_PERSISTENT	0x07

#define MEMORY_OPERATING_MODE_CAP_OTHER				(1 << 1)
 #define MEMORY_OPERATING_MODE_CAP_UNKNOWN			(1 << 2)

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35895 )

Change subject: SMBIOS (Type 17): Update the string for Intel persistent memory
......................................................................

Patch Set 1: Code-Review-1

Wasn't this long enough already? that it still compiles
even means that it's unused?

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35895 )

Change subject: SMBIOS (Type 17): Update the string for Intel persistent memory
......................................................................

Patch Set 1:
> Patch Set 1: Code-Review-1
>
> Wasn't this long enough already? that it still compiles
> even means that it's unused?

That is the string defined in SMBIOS specification v3.3.0
( https://www.dmtf.org/standards/smbios )

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35895 )

Change subject: SMBIOS (Type 17): Update the string for Intel persistent memory
......................................................................

Patch Set 1:
> Patch Set 1:
> > Patch Set 1: Code-Review-1
> >
> > Wasn't this long enough already? that it still compiles
> > even means that it's unused?
>
> That is the string defined in SMBIOS specification v3.3.0
> ( https://www.dmtf.org/standards/smbios )

note that I'm fine to drop this :)
find it too long also

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35895 )

Change subject: SMBIOS (Type 17): Update the string for Intel persistent memory
......................................................................

Patch Set 1:
> > Wasn't this long enough already? that it still compiles
> > even means that it's unused?
>
> That is the string defined in SMBIOS specification v3.3.0
> ( https://www.dmtf.org/standards/smbios )

What you change here is not a string but merely the name of
a macro. Whatever we name this macro, it has no effect on the
interface.

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35895 )

Change subject: SMBIOS (Type 17): Update the string for Intel persistent memory
......................................................................

Patch Set 1:
> > > Wasn't this long enough already? that it still compiles
> > > even means that it's unused?
> >
> > That is the string defined in SMBIOS specification v3.3.0
> > ( https://www.dmtf.org/standards/smbios )
>
> note that I'm fine to drop this :)
> find it too long also

Alternatively you can ask others for their opinion. Maybe somebody
thinks we should keep the names aligned as close as possible.
However, I wonder now: Did the name change in SMBIOS? maybe the
author of that line shortened it already on purpose??

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35895 )

Change subject: SMBIOS (Type 17): Update the string for Intel persistent memory
......................................................................

Patch Set 1:
> Patch Set 1:
> > > > Wasn't this long enough already? that it still compiles
> > > > even means that it's unused?
> > >
> > > That is the string defined in SMBIOS specification v3.3.0
> > > ( https://www.dmtf.org/standards/smbios )
> >
> > note that I'm fine to drop this :)
> > find it too long also
>
> Alternatively you can ask others for their opinion. Maybe somebody
> thinks we should keep the names aligned as close as possible.
> However, I wonder now: Did the name change in SMBIOS? maybe the
> author of that line shortened it already on purpose??

Yes, that name changed from v3.2.0 to that new one in v3.3.0

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35895 )

Change subject: SMBIOS (Type 17): Update the string for Intel persistent memory
......................................................................

Patch Set 1: -Code-Review

I'm pretty much undecided, now that I've seen even longer
identifiers... However the spec doesn't say

Intel Optane Persistent

is says

Intel(R) Optane^TM DC Persistent Memory

which would be

MEMORY_TECHNOLOGY_INTEL_R_OPTANE_TM_DC_PERSISTENT_MEMORY

Not sure if anybody would want that ^^

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/35895 )

Change subject: SMBIOS (Type 17): Update the string for Intel persistent memory
......................................................................

Abandoned