Change in coreboot[master]: SMBIOS (Type 17): Update the string for Intel persistent memory

List overview All Threads
Download

newer

older

Change in ...coreboot[master]:...

Change in coreboot[master]:...

HAOUAS Elyes (Code Review)

8 Oct 2019 8 Oct '19

9:04 a.m.

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35895 )

Change subject: SMBIOS (Type 17): Update the string for Intel persistent memory ......................................................................

SMBIOS (Type 17): Update the string for Intel persistent memory

Change-Id: I0cd49ffd05bba4ea29550659ac56ea991b697592 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/include/smbios.h 1 file changed, 7 insertions(+), 7 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/35895/1

diff --git a/src/include/smbios.h b/src/include/smbios.h index eb947dc..94b4208 100644 --- a/src/include/smbios.h +++ b/src/include/smbios.h @@ -97,13 +97,13 @@ #define MEMORY_TYPE_DETAIL_UNBUFFERED (1 << 14) #define MEMORY_TYPE_DETAIL_LRDIMM (1 << 15)

-#define MEMORY_TECHNOLOGY_OTHER 0x01 -#define MEMORY_TECHNOLOGY_UNKNOWN 0x02 -#define MEMORY_TECHNOLOGY_DRAM 0x03 -#define MEMORY_TECHNOLOGY_NVDIMM_N 0x04 -#define MEMORY_TECHNOLOGY_NVDIMM_F 0x05 -#define MEMORY_TECHNOLOGY_NVDIMM_P 0x06 -#define MEMORY_TECHNOLOGY_INTEL_PERSISTENT 0x07 +#define MEMORY_TECHNOLOGY_OTHER 0x01 +#define MEMORY_TECHNOLOGY_UNKNOWN 0x02 +#define MEMORY_TECHNOLOGY_DRAM 0x03 +#define MEMORY_TECHNOLOGY_NVDIMM_N 0x04 +#define MEMORY_TECHNOLOGY_NVDIMM_F 0x05 +#define MEMORY_TECHNOLOGY_NVDIMM_P 0x06 +#define MEMORY_TECHNOLOGY_INTEL_OPTANE_PERSISTENT 0x07

#define MEMORY_OPERATING_MODE_CAP_OTHER (1 << 1) #define MEMORY_OPERATING_MODE_CAP_UNKNOWN (1 << 2)

Attachments:

attachment.htm (text/html — 3.5 KB)

Show replies by date

Nico Huber (Code Review)

8 Oct 8 Oct

10:05 a.m.

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35895 )

Change subject: SMBIOS (Type 17): Update the string for Intel persistent memory ......................................................................

Patch Set 1: Code-Review-1

Wasn't this long enough already? that it still compiles even means that it's unused?

-- To view, visit https://review.coreboot.org/c/coreboot/+/35895 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0cd49ffd05bba4ea29550659ac56ea991b697592 Gerrit-Change-Number: 35895 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 08 Oct 2019 16:05:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

11:33 a.m.

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35895 )

Change subject: SMBIOS (Type 17): Update the string for Intel persistent memory ......................................................................

Patch Set 1:

...

Patch Set 1: Code-Review-1

Wasn't this long enough already? that it still compiles even means that it's unused?

That is the string defined in SMBIOS specification v3.3.0 ( https://www.dmtf.org/standards/smbios )

-- To view, visit https://review.coreboot.org/c/coreboot/+/35895 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0cd49ffd05bba4ea29550659ac56ea991b697592 Gerrit-Change-Number: 35895 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 08 Oct 2019 17:33:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

11:39 a.m.

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35895 )

Change subject: SMBIOS (Type 17): Update the string for Intel persistent memory ......................................................................

Patch Set 1:

...

Patch Set 1:

...
Patch Set 1: Code-Review-1

Wasn't this long enough already? that it still compiles even means that it's unused?

That is the string defined in SMBIOS specification v3.3.0 ( https://www.dmtf.org/standards/smbios )

note that I'm fine to drop this :) find it too long also

-- To view, visit https://review.coreboot.org/c/coreboot/+/35895 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0cd49ffd05bba4ea29550659ac56ea991b697592 Gerrit-Change-Number: 35895 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 08 Oct 2019 17:39:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Nico Huber (Code Review)

9 Oct 9 Oct

2:12 a.m.

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35895 )

Change subject: SMBIOS (Type 17): Update the string for Intel persistent memory ......................................................................

Patch Set 1:

...

...
Wasn't this long enough already? that it still compiles even means that it's unused?

That is the string defined in SMBIOS specification v3.3.0 ( https://www.dmtf.org/standards/smbios )

What you change here is not a string but merely the name of a macro. Whatever we name this macro, it has no effect on the interface.

-- To view, visit https://review.coreboot.org/c/coreboot/+/35895 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0cd49ffd05bba4ea29550659ac56ea991b697592 Gerrit-Change-Number: 35895 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 09 Oct 2019 08:12:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Nico Huber (Code Review)

2:16 a.m.

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35895 )

Change subject: SMBIOS (Type 17): Update the string for Intel persistent memory ......................................................................

Patch Set 1:

...

...
...
Wasn't this long enough already? that it still compiles even means that it's unused?

That is the string defined in SMBIOS specification v3.3.0 ( https://www.dmtf.org/standards/smbios )

note that I'm fine to drop this :) find it too long also

Alternatively you can ask others for their opinion. Maybe somebody thinks we should keep the names aligned as close as possible. However, I wonder now: Did the name change in SMBIOS? maybe the author of that line shortened it already on purpose??

-- To view, visit https://review.coreboot.org/c/coreboot/+/35895 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0cd49ffd05bba4ea29550659ac56ea991b697592 Gerrit-Change-Number: 35895 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 09 Oct 2019 08:16:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

2:30 a.m.

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35895 )

Change subject: SMBIOS (Type 17): Update the string for Intel persistent memory ......................................................................

Patch Set 1:

...

Patch Set 1:

...
...
...
Wasn't this long enough already? that it still compiles even means that it's unused?

That is the string defined in SMBIOS specification v3.3.0 ( https://www.dmtf.org/standards/smbios )

note that I'm fine to drop this :) find it too long also

Alternatively you can ask others for their opinion. Maybe somebody thinks we should keep the names aligned as close as possible. However, I wonder now: Did the name change in SMBIOS? maybe the author of that line shortened it already on purpose??

Yes, that name changed from v3.2.0 to that new one in v3.3.0

-- To view, visit https://review.coreboot.org/c/coreboot/+/35895 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0cd49ffd05bba4ea29550659ac56ea991b697592 Gerrit-Change-Number: 35895 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 09 Oct 2019 08:30:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Nico Huber (Code Review)

4:46 a.m.

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35895 )

Change subject: SMBIOS (Type 17): Update the string for Intel persistent memory ......................................................................

Patch Set 1: -Code-Review

I'm pretty much undecided, now that I've seen even longer identifiers... However the spec doesn't say

Intel Optane Persistent

is says

Intel(R) Optane^TM DC Persistent Memory

which would be

MEMORY_TECHNOLOGY_INTEL_R_OPTANE_TM_DC_PERSISTENT_MEMORY

Not sure if anybody would want that ^^

-- To view, visit https://review.coreboot.org/c/coreboot/+/35895 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0cd49ffd05bba4ea29550659ac56ea991b697592 Gerrit-Change-Number: 35895 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 09 Oct 2019 10:46:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

13 Dec 13 Dec

9:39 a.m.

HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/35895 )

Change subject: SMBIOS (Type 17): Update the string for Intel persistent memory ......................................................................

Abandoned

1979

days inactive

2045

days old

coreboot-gerrit@coreboot.org

8 comments

2 participants

tags (0)

participants (2)

HAOUAS Elyes (Code Review)
Nico Huber (Code Review)