Change in coreboot[master]: device/pnp_ops.h: Use pnp.h functions

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Angel Pons (Code Review)

6 Jun 2020 6 Jun '20

6:09 p.m.

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42133 )

Change subject: device/pnp_ops.h: Use pnp.h functions ......................................................................

device/pnp_ops.h: Use pnp.h functions

With BUILD_TIMELESS=1, Asrock B85M Pro4 remains identical.

Change-Id: I3ca080e700cf7b7f5b76cadddc7e41960413433c Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/include/device/pnp_ops.h 1 file changed, 3 insertions(+), 6 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/42133/1

diff --git a/src/include/device/pnp_ops.h b/src/include/device/pnp_ops.h index 039c9aa..0cfdd61 100644 --- a/src/include/device/pnp_ops.h +++ b/src/include/device/pnp_ops.h @@ -5,6 +5,7 @@

#include <stdint.h> #include <arch/io.h> +#include <device/pnp.h> #include <device/pnp_type.h>

#if ENV_PNP_SIMPLE_DEVICE @@ -12,17 +13,13 @@ static __always_inline void pnp_write_config( pnp_devfn_t dev, uint8_t reg, uint8_t value) { - unsigned int port = dev >> 8; - outb(reg, port); - outb(value, port + 1); + pnp_write_index(dev >> 8, reg, value); }

static __always_inline uint8_t pnp_read_config( pnp_devfn_t dev, uint8_t reg) { - unsigned int port = dev >> 8; - outb(reg, port); - return inb(port + 1); + return pnp_read_index(dev >> 8, reg); }

static __always_inline

Attachments:

attachment.htm (text/html — 3.3 KB)

Show replies by date

HAOUAS Elyes (Code Review)

7 Jun 7 Jun

1:39 a.m.

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42133 )

Change subject: device/pnp_ops.h: Use pnp.h functions ......................................................................

Patch Set 1: Code-Review+1

(1 comment)

https://review.coreboot.org/c/coreboot/+/42133/1/src/include/device/pnp_ops.... File src/include/device/pnp_ops.h:

https://review.coreboot.org/c/coreboot/+/42133/1/src/include/device/pnp_ops.... PS1, Line 13: static __always_inline void pnp_write_config( : pnp_devfn_t dev, uint8_t reg, uint8_t value) while at it ?: static __always_inline void pnp_write_config(pnp_devfn_t dev, uint8_t reg, uint8_t value)

-- To view, visit https://review.coreboot.org/c/coreboot/+/42133 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3ca080e700cf7b7f5b76cadddc7e41960413433c Gerrit-Change-Number: 42133 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sun, 07 Jun 2020 07:39:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Angel Pons (Code Review)

3:06 a.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42133 )

Change subject: device/pnp_ops.h: Use pnp.h functions ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/42133/1/src/include/device/pnp_ops.... File src/include/device/pnp_ops.h:

https://review.coreboot.org/c/coreboot/+/42133/1/src/include/device/pnp_ops.... PS1, Line 13: static __always_inline void pnp_write_config( : pnp_devfn_t dev, uint8_t reg, uint8_t value)

...

while at it ?: […]

I'd do this on a separate change.

-- To view, visit https://review.coreboot.org/c/coreboot/+/42133 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3ca080e700cf7b7f5b76cadddc7e41960413433c Gerrit-Change-Number: 42133 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sun, 07 Jun 2020 09:06:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: HAOUAS Elyes ehaouas@noos.fr Gerrit-MessageType: comment

Angel Pons (Code Review)

15 Jun 15 Jun

8:23 a.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42133 )

Change subject: device/pnp_ops.h: Use pnp.h functions ......................................................................

Patch Set 1:

This change is ready for review.

-- To view, visit https://review.coreboot.org/c/coreboot/+/42133 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3ca080e700cf7b7f5b76cadddc7e41960413433c Gerrit-Change-Number: 42133 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 15 Jun 2020 14:23:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Paul Menzel (Code Review)

16 Jun 16 Jun

11:27 a.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42133 )

Change subject: device/pnp_ops.h: Use pnp.h functions ......................................................................

Patch Set 3: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/42133 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3ca080e700cf7b7f5b76cadddc7e41960413433c Gerrit-Change-Number: 42133 Gerrit-PatchSet: 3 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 16 Jun 2020 17:27:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

8:45 p.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42133 )

Change subject: device/pnp_ops.h: Use pnp.h functions ......................................................................

Patch Set 4: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/42133 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3ca080e700cf7b7f5b76cadddc7e41960413433c Gerrit-Change-Number: 42133 Gerrit-PatchSet: 4 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 17 Jun 2020 02:45:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Felix Held (Code Review)

17 Jun 17 Jun

12:17 p.m.

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42133 )

Change subject: device/pnp_ops.h: Use pnp.h functions ......................................................................

device/pnp_ops.h: Use pnp.h functions

With BUILD_TIMELESS=1, Asrock B85M Pro4 remains identical.

Change-Id: I3ca080e700cf7b7f5b76cadddc7e41960413433c Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/42133 Reviewed-by: Furquan Shaikh furquan@google.com Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: HAOUAS Elyes ehaouas@noos.fr Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/include/device/pnp_ops.h 1 file changed, 3 insertions(+), 6 deletions(-)

Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Furquan Shaikh: Looks good to me, approved HAOUAS Elyes: Looks good to me, but someone else must approve

diff --git a/src/include/device/pnp_ops.h b/src/include/device/pnp_ops.h index 039c9aa..0cfdd61 100644 --- a/src/include/device/pnp_ops.h +++ b/src/include/device/pnp_ops.h @@ -5,6 +5,7 @@

#include <stdint.h> #include <arch/io.h> +#include <device/pnp.h> #include <device/pnp_type.h>

static __always_inline uint8_t pnp_read_config( pnp_devfn_t dev, uint8_t reg) { - unsigned int port = dev >> 8; - outb(reg, port); - return inb(port + 1); + return pnp_read_index(dev >> 8, reg); }

static __always_inline

-- To view, visit https://review.coreboot.org/c/coreboot/+/42133 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3ca080e700cf7b7f5b76cadddc7e41960413433c Gerrit-Change-Number: 42133 Gerrit-PatchSet: 5 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

1791

days inactive

1801

days old

coreboot-gerrit@coreboot.org

6 comments

5 participants

tags (0)

participants (5)

Angel Pons (Code Review)
Felix Held (Code Review)
Furquan Shaikh (Code Review)
HAOUAS Elyes (Code Review)
Paul Menzel (Code Review)