Change in coreboot[master]: soc/amd/stoneyridge/acpi/sb_pci0_fch: remove duplicate I/O range

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Felix Held (Code Review)

14 Sep 2020 14 Sep '20

8:30 p.m.

Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45369 )

Change subject: soc/amd/stoneyridge/acpi/sb_pci0_fch: remove duplicate I/O range ......................................................................

soc/amd/stoneyridge/acpi/sb_pci0_fch: remove duplicate I/O range

This I/O region is already covered by the range declared right above the deleted one.

Change-Id: I8b8ff3385bbba8e69101ee2c5a5cb39c8f996b94 Signed-off-by: Felix Held felix-coreboot@felixheld.de --- M src/soc/amd/stoneyridge/acpi/sb_pci0_fch.asl 1 file changed, 0 insertions(+), 7 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/45369/1

diff --git a/src/soc/amd/stoneyridge/acpi/sb_pci0_fch.asl b/src/soc/amd/stoneyridge/acpi/sb_pci0_fch.asl index 64e8748..1820f7a 100644 --- a/src/soc/amd/stoneyridge/acpi/sb_pci0_fch.asl +++ b/src/soc/amd/stoneyridge/acpi/sb_pci0_fch.asl @@ -75,13 +75,6 @@ 0x0000, /* translation */ 0x0cf8 /* length */ ) - WORDIO(ResourceProducer, MinFixed, MaxFixed, PosDecode, EntireRange, - 0x0000, /* address granularity */ - 0x03b0, /* range minimum */ - 0x03df, /* range maximum */ - 0x0000, /* translation */ - 0x0030 /* length */ - )

WORDIO(ResourceProducer, MinFixed, MaxFixed, PosDecode, EntireRange, 0x0000, /* address granularity */

Attachments:

attachment.htm (text/html — 2.9 KB)

Show replies by date

Aaron Durbin (Code Review)

14 Sep 14 Sep

8:31 p.m.

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45369 )

Change subject: soc/amd/stoneyridge/acpi/sb_pci0_fch: remove duplicate I/O range ......................................................................

Patch Set 1: Code-Review+2

Felix Held (Code Review)

8:31 p.m.

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45369 )

Change subject: soc/amd/stoneyridge/acpi/sb_pci0_fch: remove duplicate I/O range ......................................................................

Patch Set 1:

this one is untested, but the code in picasso was copied over from stoneyridge, so it should fix that issue there as well

-- To view, visit https://review.coreboot.org/c/coreboot/+/45369 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8b8ff3385bbba8e69101ee2c5a5cb39c8f996b94 Gerrit-Change-Number: 45369 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Raul Rangel rrangel@chromium.org Gerrit-Comment-Date: Mon, 14 Sep 2020 18:31:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Raul Rangel (Code Review)

8:50 p.m.

Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45369 )

Change subject: soc/amd/stoneyridge/acpi/sb_pci0_fch: remove duplicate I/O range ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/45369 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8b8ff3385bbba8e69101ee2c5a5cb39c8f996b94 Gerrit-Change-Number: 45369 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Raul Rangel rrangel@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 14 Sep 2020 18:50:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Marshall Dawson (Code Review)

15 Sep 15 Sep

12:14 a.m.

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45369 )

Change subject: soc/amd/stoneyridge/acpi/sb_pci0_fch: remove duplicate I/O range ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/45369 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8b8ff3385bbba8e69101ee2c5a5cb39c8f996b94 Gerrit-Change-Number: 45369 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Raul Rangel rrangel@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 14 Sep 2020 22:14:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

2:15 a.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45369 )

Change subject: soc/amd/stoneyridge/acpi/sb_pci0_fch: remove duplicate I/O range ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/45369 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8b8ff3385bbba8e69101ee2c5a5cb39c8f996b94 Gerrit-Change-Number: 45369 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Raul Rangel rrangel@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 15 Sep 2020 00:15:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Felix Held (Code Review)

9:31 p.m.

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45369 )

Change subject: soc/amd/stoneyridge/acpi/sb_pci0_fch: remove duplicate I/O range ......................................................................

soc/amd/stoneyridge/acpi/sb_pci0_fch: remove duplicate I/O range

This I/O region is already covered by the range declared right above the deleted one.

Change-Id: I8b8ff3385bbba8e69101ee2c5a5cb39c8f996b94 Signed-off-by: Felix Held felix-coreboot@felixheld.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/45369 Reviewed-by: Aaron Durbin adurbin@chromium.org Reviewed-by: Raul Rangel rrangel@chromium.org Reviewed-by: Marshall Dawson marshalldawson3rd@gmail.com Reviewed-by: Furquan Shaikh furquan@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/amd/stoneyridge/acpi/sb_pci0_fch.asl 1 file changed, 0 insertions(+), 7 deletions(-)

Approvals: build bot (Jenkins): Verified Aaron Durbin: Looks good to me, approved Furquan Shaikh: Looks good to me, approved Marshall Dawson: Looks good to me, approved Raul Rangel: Looks good to me, approved

WORDIO(ResourceProducer, MinFixed, MaxFixed, PosDecode, EntireRange, 0x0000, /* address granularity */

-- To view, visit https://review.coreboot.org/c/coreboot/+/45369 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8b8ff3385bbba8e69101ee2c5a5cb39c8f996b94 Gerrit-Change-Number: 45369 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Raul Rangel rrangel@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

9elements QA (Code Review)

10:52 p.m.

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45369 )

Change subject: soc/amd/stoneyridge/acpi/sb_pci0_fch: remove duplicate I/O range ......................................................................

Patch Set 2:

Automatic boot test returned (PASS/FAIL/TOTAL): 8/1/9 "QEMU x86 q35/ich9" (x86_32) using payload TianoCore : SUCCESS : https://lava.9esec.io/r/19470 "QEMU x86 q35/ich9" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/19469 "QEMU x86 i440fx/piix4" (x86_64) using payload SeaBIOS : FAIL : https://lava.9esec.io/r/19468 "QEMU x86 i440fx/piix4" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/19467 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/19466 "HP Z220 SFF Workstation" (x86_32) using payload LinuxBoot_BusyBox_kexec : SUCCESS : https://lava.9esec.io/r/19474 "HP Z220 SFF Workstation" (x86_32) using payload LinuxBoot_BusyBox_kexec : SUCCESS : https://lava.9esec.io/r/19473 "HP Compaq 8200 Elite SFF PC" (x86_32) using payload TianoCore : SUCCESS : https://lava.9esec.io/r/19472 "HP Compaq 8200 Elite SFF PC" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/19471

Please note: This test is under development and might not be accurate at all!

-- To view, visit https://review.coreboot.org/c/coreboot/+/45369 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8b8ff3385bbba8e69101ee2c5a5cb39c8f996b94 Gerrit-Change-Number: 45369 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Raul Rangel rrangel@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com Gerrit-Comment-Date: Tue, 15 Sep 2020 20:52:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1523

days inactive

1524

days old

coreboot-gerrit@coreboot.org

7 comments

6 participants

tags (0)

participants (6)

9elements QA (Code Review)
Aaron Durbin (Code Review)
Felix Held (Code Review)
Furquan Shaikh (Code Review)
Marshall Dawson (Code Review)
Raul Rangel (Code Review)