Francois Toguo Fotso has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49799 )
Change subject: acpi: Add support for reporting CrashLog in BERT table
......................................................................
Patch Set 10:
(1 comment)
Patchset:
PS10:
The generic code is currently there already, and working as indented in the common acpi to generate the BERT file/table from either the Intel or AMD. Again I don't see the need to change it.
Could you please point to the common code dupplicated by https://review.coreboot.org/c/coreboot/+/49799/10/src/acpi/acpi.c#1585 ?
The functions introduced are declared as "__weak". That concept gives it the option for to refined elsewhere. Which actually makes it generic for redefinition/re-use in your ADM flow if you wish.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49799
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I00e390d735d61beac2e89a726e39119d9b06b3df
Gerrit-Change-Number: 49799
Gerrit-PatchSet: 10
Gerrit-Owner: Francois Toguo Fotso
francois.toguo.fotso@intel.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nikunj Dadhania
nikunj.dadhania@intel.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Raj Astekar
raj.astekar@intel.com
Gerrit-Comment-Date: Thu, 27 May 2021 17:42:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment