Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40414 )
Change subject: lib/spd_bin: add get_spd_sn function ......................................................................
Patch Set 2:
(4 comments)
Just some minor things I noticed Jamie that you could address on your next iteration.
https://review.coreboot.org/c/coreboot/+/40414/2/src/soc/intel/common/block/... File src/soc/intel/common/block/smbus/smbuslib.c:
https://review.coreboot.org/c/coreboot/+/40414/2/src/soc/intel/common/block/... PS2, Line 79: int unsigned
https://review.coreboot.org/c/coreboot/+/40414/2/src/soc/intel/common/block/... PS2, Line 82: addr << 1); I think you can fit this on the line above.
https://review.coreboot.org/c/coreboot/+/40414/2/src/soc/intel/common/block/... PS2, Line 94: s/\t/ /
https://review.coreboot.org/c/coreboot/+/40414/2/src/soc/intel/common/block/... PS2, Line 100: s/\t/ /
-
Edward O'Callaghan (Code Review)