Attention is currently required from: Raul Rangel, Kangheui Won, Felix Held. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55136 )
Change subject: mb/google/guybrush: initialize i2c in psp_verstage ......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/guybrush/verstage.c:
https://review.coreboot.org/c/coreboot/+/55136/comment/abfa5ec1_eceb92a2 PS1, Line 28: if (CONFIG(VBOOT_STARTS_BEFORE_BOOTBLOCK)) { : enable_aoac_devices(); : printk(BIOS_DEBUG, "Setting up i2c\n"); : i2c_soc_early_init(); : printk(BIOS_DEBUG, "i2c setup\n"); : }
I thought i2c is only used for the communication with GSC so the code is specific to guybrush. […]
i2c_soc_early_init() takes care of initializing only those I2C buses which are marked for early_init. Also, psp_verstage is specific to Chrome OS anyways. I don't think it hurts to initialize the AOAC power for the aoac_devs as part of SoC code. It is anyways required for all Chrome OS mainboards.
Also, these calls will be eventually duplicated across all Chrome OS mainboards which seems unnecessary. There is no mainboard specific element to it.