Change in ...coreboot[master]: soc/{samsung,sifive}: Use 'include <stdlib.h>' when appropriate

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33689

Change subject: soc/{samsung,sifive}: Use 'include <stdlib.h>' when appropriate
......................................................................

soc/{samsung,sifive}: Use 'include <stdlib.h>' when appropriate

Change-Id: I6a933295de7c41d62e6a95f955c098b49ea17f08
Signed-off-by: Elyes HAOUAS 
---
M src/soc/samsung/exynos5250/spi.c
M src/soc/samsung/exynos5420/spi.c
M src/soc/sifive/fu540/clock.c
3 files changed, 3 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/33689/1

diff --git a/src/soc/samsung/exynos5250/spi.c b/src/soc/samsung/exynos5250/spi.c
index e35f888..592cefa 100644
--- a/src/soc/samsung/exynos5250/spi.c
+++ b/src/soc/samsung/exynos5250/spi.c
@@ -21,7 +21,7 @@
 #include <soc/clk.h>
 #include <soc/gpio.h>
 #include <soc/spi.h>
-#include <stdlib.h>
+#include <stddef.h>
 #include <symbols.h>

#if defined(CONFIG_DEBUG_SPI) && CONFIG_DEBUG_SPI
diff --git a/src/soc/samsung/exynos5420/spi.c b/src/soc/samsung/exynos5420/spi.c
index 1903f6b..8081b1c 100644
--- a/src/soc/samsung/exynos5420/spi.c
+++ b/src/soc/samsung/exynos5420/spi.c
@@ -20,7 +20,7 @@
 #include <soc/cpu.h>
 #include <soc/spi.h>
 #include <spi-generic.h>
-#include <stdlib.h>
+#include <stddef.h>
 #include <string.h>
 #include <symbols.h>

diff --git a/src/soc/sifive/fu540/clock.c b/src/soc/sifive/fu540/clock.c
index 60a8a13..0685ce6 100644
--- a/src/soc/sifive/fu540/clock.c
+++ b/src/soc/sifive/fu540/clock.c
@@ -17,7 +17,7 @@
 #include <console/console.h>
 #include <soc/clock.h>
 #include <soc/addressmap.h>
-#include <stdlib.h>
+#include <stddef.h>
 #include <stdint.h>

// 33.33 Mhz after reset

Change in coreboot[master]: soc/{samsung,sifive}: Use 'include <stdlib.h>' when appropriate

[HAOUAS Elyes (Code Review)]

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33689

to look at the new patch set (#4).

Change subject: soc/{samsung,sifive}: Use 'include <stdlib.h>' when appropriate
......................................................................

soc/{samsung,sifive}: Use 'include <stdlib.h>' when appropriate

Also including <types.h>, is supposed to provide stdint and stddef.

Change-Id: I6a933295de7c41d62e6a95f955c098b49ea17f08
Signed-off-by: Elyes HAOUAS 
---
M src/soc/samsung/exynos5250/spi.c
M src/soc/samsung/exynos5420/spi.c
M src/soc/sifive/fu540/clock.c
3 files changed, 3 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/33689/4

Change in coreboot[master]: soc/{samsung,sifive}: Use 'include <stdlib.h>' when appropriate

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/33689 )

Change subject: soc/{samsung,sifive}: Use 'include <stdlib.h>' when appropriate
......................................................................

Abandoned

see 32023

Change in coreboot[master]: soc/{samsung,sifive}: Use 'include <stdlib.h>' when appropriate

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has restored this change. ( https://review.coreboot.org/c/coreboot/+/33689 )

Change subject: soc/{samsung,sifive}: Use 'include <stdlib.h>' when appropriate
......................................................................

Restored

Change in coreboot[master]: src/soc/samsung: Remove unused <stdlib.h>

[HAOUAS Elyes (Code Review)]

Hello ron minnich, Jonathan Neuschäfer, build bot (Jenkins), Philipp Hug,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33689

to look at the new patch set (#5).

Change subject: src/soc/samsung: Remove unused <stdlib.h>
......................................................................

src/soc/samsung: Remove unused <stdlib.h>

Change-Id: I6a933295de7c41d62e6a95f955c098b49ea17f08
Signed-off-by: Elyes HAOUAS 
---
M src/soc/samsung/exynos5250/alternate_cbfs.c
M src/soc/samsung/exynos5250/clock.c
M src/soc/samsung/exynos5250/cpu.c
M src/soc/samsung/exynos5250/fb.c
M src/soc/samsung/exynos5250/spi.c
M src/soc/samsung/exynos5420/alternate_cbfs.c
M src/soc/samsung/exynos5420/clock.c
M src/soc/samsung/exynos5420/cpu.c
M src/soc/samsung/exynos5420/dp.c
M src/soc/samsung/exynos5420/dp_lowlevel.c
M src/soc/samsung/exynos5420/pinmux.c
M src/soc/samsung/exynos5420/smp.c
M src/soc/samsung/exynos5420/spi.c
13 files changed, 0 insertions(+), 13 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/33689/5

Change in coreboot[master]: src/soc/samsung: Remove unused <stdlib.h>

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33689 )

Change subject: src/soc/samsung: Remove unused <stdlib.h>
......................................................................

Patch Set 9: Code-Review+2

Change in coreboot[master]: src/soc/samsung: Remove unused <stdlib.h>

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has submitted this change. ( https://review.coreboot.org/c/coreboot/+/33689 )

Change subject: src/soc/samsung: Remove unused <stdlib.h>
......................................................................

src/soc/samsung: Remove unused <stdlib.h>

Change-Id: I6a933295de7c41d62e6a95f955c098b49ea17f08
Signed-off-by: Elyes HAOUAS 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/33689
Reviewed-by: Kyösti Mälkki 
Tested-by: build bot (Jenkins) 
---
M src/soc/samsung/exynos5250/alternate_cbfs.c
M src/soc/samsung/exynos5250/clock.c
M src/soc/samsung/exynos5250/cpu.c
M src/soc/samsung/exynos5250/fb.c
M src/soc/samsung/exynos5250/spi.c
M src/soc/samsung/exynos5420/alternate_cbfs.c
M src/soc/samsung/exynos5420/clock.c
M src/soc/samsung/exynos5420/cpu.c
M src/soc/samsung/exynos5420/dp.c
M src/soc/samsung/exynos5420/dp_lowlevel.c
M src/soc/samsung/exynos5420/pinmux.c
M src/soc/samsung/exynos5420/smp.c
M src/soc/samsung/exynos5420/spi.c
13 files changed, 0 insertions(+), 13 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Kyösti Mälkki: Looks good to me, approved

diff --git a/src/soc/samsung/exynos5250/alternate_cbfs.c b/src/soc/samsung/exynos5250/alternate_cbfs.c
index c319019..1ff5d85 100644
--- a/src/soc/samsung/exynos5250/alternate_cbfs.c
+++ b/src/soc/samsung/exynos5250/alternate_cbfs.c
@@ -18,7 +18,6 @@
 #include <soc/alternate_cbfs.h>
 #include <soc/power.h>
 #include <soc/spi.h>
-#include <stdlib.h>
 #include <symbols.h>

/* This allows USB A-A firmware upload from a compatible host in four parts:
diff --git a/src/soc/samsung/exynos5250/clock.c b/src/soc/samsung/exynos5250/clock.c
index e762af1..f1b11b5 100644
--- a/src/soc/samsung/exynos5250/clock.c
+++ b/src/soc/samsung/exynos5250/clock.c
@@ -18,7 +18,6 @@
 #include <console/console.h>
 #include <soc/clk.h>
 #include <soc/periph.h>
-#include <stdlib.h>
 #include <timer.h>

/* input clock of PLL: SMDK5250 has 24MHz input clock */
diff --git a/src/soc/samsung/exynos5250/cpu.c b/src/soc/samsung/exynos5250/cpu.c
index f00351e..5f99899 100644
--- a/src/soc/samsung/exynos5250/cpu.c
+++ b/src/soc/samsung/exynos5250/cpu.c
@@ -23,7 +23,6 @@
 #include <soc/dp-core.h>
 #include <soc/fimd.h>
 #include <stddef.h>
-#include <stdlib.h>
 #include <string.h>

#include "chip.h"
diff --git a/src/soc/samsung/exynos5250/fb.c b/src/soc/samsung/exynos5250/fb.c
index 2e8acf2..a29c619 100644
--- a/src/soc/samsung/exynos5250/fb.c
+++ b/src/soc/samsung/exynos5250/fb.c
@@ -25,7 +25,6 @@
 #include <soc/i2c.h>
 #include <soc/power.h>
 #include <soc/sysreg.h>
-#include <stdlib.h>
 #include <timer.h>

/*
diff --git a/src/soc/samsung/exynos5250/spi.c b/src/soc/samsung/exynos5250/spi.c
index 4d5e01f..bacd08c 100644
--- a/src/soc/samsung/exynos5250/spi.c
+++ b/src/soc/samsung/exynos5250/spi.c
@@ -21,7 +21,6 @@
 #include <soc/clk.h>
 #include <soc/gpio.h>
 #include <soc/spi.h>
-#include <stdlib.h>
 #include <symbols.h>

#if defined(CONFIG_DEBUG_SPI) && CONFIG_DEBUG_SPI
diff --git a/src/soc/samsung/exynos5420/alternate_cbfs.c b/src/soc/samsung/exynos5420/alternate_cbfs.c
index fabc9cf..deb4f02 100644
--- a/src/soc/samsung/exynos5420/alternate_cbfs.c
+++ b/src/soc/samsung/exynos5420/alternate_cbfs.c
@@ -19,7 +19,6 @@
 #include <soc/alternate_cbfs.h>
 #include <soc/power.h>
 #include <soc/spi.h>
-#include <stdlib.h>
 #include <symbols.h>

/* This allows USB A-A firmware upload from a compatible host in four parts:
diff --git a/src/soc/samsung/exynos5420/clock.c b/src/soc/samsung/exynos5420/clock.c
index fe11cde..acfab97 100644
--- a/src/soc/samsung/exynos5420/clock.c
+++ b/src/soc/samsung/exynos5420/clock.c
@@ -18,7 +18,6 @@
 #include <console/console.h>
 #include <soc/clk.h>
 #include <soc/periph.h>
-#include <stdlib.h>
 #include <timer.h>

/* input clock of PLL: SMDK5420 has 24MHz input clock */
diff --git a/src/soc/samsung/exynos5420/cpu.c b/src/soc/samsung/exynos5420/cpu.c
index 55b0512..375b370 100644
--- a/src/soc/samsung/exynos5420/cpu.c
+++ b/src/soc/samsung/exynos5420/cpu.c
@@ -24,7 +24,6 @@
 #include <soc/cpu.h>
 #include <soc/clk.h>
 #include <stddef.h>
-#include <stdlib.h>
 #include <string.h>

#include "chip.h"
diff --git a/src/soc/samsung/exynos5420/dp.c b/src/soc/samsung/exynos5420/dp.c
index 5ad3dd3..c48ea8c 100644
--- a/src/soc/samsung/exynos5420/dp.c
+++ b/src/soc/samsung/exynos5420/dp.c
@@ -21,7 +21,6 @@
 #include <soc/i2c.h>
 #include <soc/power.h>
 #include <soc/sysreg.h>
-#include <stdlib.h>
 #include <string.h>

/*
diff --git a/src/soc/samsung/exynos5420/dp_lowlevel.c b/src/soc/samsung/exynos5420/dp_lowlevel.c
index 164704b..df579b0 100644
--- a/src/soc/samsung/exynos5420/dp_lowlevel.c
+++ b/src/soc/samsung/exynos5420/dp_lowlevel.c
@@ -22,7 +22,6 @@
 #include <soc/i2c.h>
 #include <soc/power.h>
 #include <soc/sysreg.h>
-#include <stdlib.h>

/* FIXME: I think the DP controller shouldn't be hardcoded here... */
 static struct exynos_dp * const dp_regs = (void *)EXYNOS5_DP1_BASE;
diff --git a/src/soc/samsung/exynos5420/pinmux.c b/src/soc/samsung/exynos5420/pinmux.c
index 999afa0..347c669 100644
--- a/src/soc/samsung/exynos5420/pinmux.c
+++ b/src/soc/samsung/exynos5420/pinmux.c
@@ -15,7 +15,6 @@

#include <soc/gpio.h>
 #include <soc/pinmux.h>
-#include <stdlib.h>

static void exynos_pinmux_uart(int start, int count)
 {
diff --git a/src/soc/samsung/exynos5420/smp.c b/src/soc/samsung/exynos5420/smp.c
index 5e16063..27c0fa6 100644
--- a/src/soc/samsung/exynos5420/smp.c
+++ b/src/soc/samsung/exynos5420/smp.c
@@ -18,7 +18,6 @@
 #include <device/mmio.h>
 #include <soc/cpu.h>
 #include <soc/power.h>
-#include <stdlib.h>
 #include <string.h>
 #include <types.h>

diff --git a/src/soc/samsung/exynos5420/spi.c b/src/soc/samsung/exynos5420/spi.c
index 5637b02..a98f51d 100644
--- a/src/soc/samsung/exynos5420/spi.c
+++ b/src/soc/samsung/exynos5420/spi.c
@@ -20,7 +20,6 @@
 #include <soc/cpu.h>
 #include <soc/spi.h>
 #include <spi-generic.h>
-#include <stdlib.h>
 #include <string.h>
 #include <symbols.h>