Attention is currently required from: Hung-Te Lin, Yu-Ping Wu, Yidi Lin.
Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52668 )
Change subject: soc/mediatek/mt8195: add pmif/spmi/pmic driver
......................................................................
Patch Set 7:
(1 comment)
File src/soc/mediatek/mt8195/pmif_clk.c:
https://review.coreboot.org/c/coreboot/+/52668/comment/e4cb1132_20a880a1
PS6, Line 114: printk(BIOS_ERR, "[%s] calibration fail: current_val = %d, \
Avoid line continuations in quoted strings […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52668
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I73f9c9bf92837f262c15758f16dacf52261dd3a3
Gerrit-Change-Number: 52668
Gerrit-PatchSet: 7
Gerrit-Owner: Rex-BC Chen
rex-bc.chen@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidi.lin@mediatek.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Yidi Lin
yidi.lin@mediatek.com
Gerrit-Comment-Date: Tue, 04 May 2021 01:40:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Gerrit-MessageType: comment