PraveenX Hodagatta Pranesh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36450 )
Change subject: mb/intel/saddlebrook: Select coreboot MP init ......................................................................
mb/intel/saddlebrook: Select coreboot MP init
use coreboot MP init for saddlebrook by default.
BUG=None TEST=Boot till linux on saddlebrook and verified the AP's proper initialization using 'cat /proc/cpuinfo' command.
Change-Id: I2db2fe92c8ba0e649dccf95ce804a97ae4a05603 Signed-off-by: Praveen Hodagatta Pranesh praveenx.hodagatta.pranesh@intel.com --- M src/mainboard/intel/saddlebrook/Kconfig 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/36450/1
diff --git a/src/mainboard/intel/saddlebrook/Kconfig b/src/mainboard/intel/saddlebrook/Kconfig index cd18541..315104e 100644 --- a/src/mainboard/intel/saddlebrook/Kconfig +++ b/src/mainboard/intel/saddlebrook/Kconfig @@ -30,7 +30,6 @@ select SUPERIO_NUVOTON_NCT6776_COM_A select HAVE_CMOS_DEFAULT select MAINBOARD_USES_IFD_GBE_REGION - select USE_INTEL_FSP_MP_INIT
config IRQ_SLOT_COUNT int
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36450 )
Change subject: mb/intel/saddlebrook: Select coreboot MP init ......................................................................
Patch Set 1: Code-Review+1
Was it not working with USE_INTEL_FSP_MP_INIT selected?
As this is the last board that selected it, should we remove the option?
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36450 )
Change subject: mb/intel/saddlebrook: Select coreboot MP init ......................................................................
Patch Set 1: Code-Review+1
As this is the last board that selected it, should we remove the option?
Yes, please! I don't think it makes sense to have support for blob functionality when a fully working open source alternative exists. (same holds true for FSP-T on FSP2.0)
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36450 )
Change subject: mb/intel/saddlebrook: Select coreboot MP init ......................................................................
Patch Set 1:
Patch Set 1: Code-Review+1
As this is the last board that selected it, should we remove the option?
Yes, please! I don't think it makes sense to have support for blob functionality when a fully working open source alternative exists. (same holds true for FSP-T on FSP2.0)
Full ACK!
PraveenX Hodagatta Pranesh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36450 )
Change subject: mb/intel/saddlebrook: Select coreboot MP init ......................................................................
Patch Set 1:
Patch Set 1: Code-Review+1
Was it not working with USE_INTEL_FSP_MP_INIT selected?
As this is the last board that selected it, should we remove the option?
boot fine till payload shell with USE_INTEL_FSP_MP_INIT selected, but yocto linux 2.7 cannot boot hence switch to CB MP init.
Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36450 )
Change subject: mb/intel/saddlebrook: Select coreboot MP init ......................................................................
Patch Set 1:
Can we probably fix our MP init that it works again?
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36450 )
Change subject: mb/intel/saddlebrook: Select coreboot MP init ......................................................................
Patch Set 1:
Patch Set 1:
Can we probably fix our MP init that it works again?
i believe this is SKL code so our old implementation should i mean no need to use PPI way to do MP init now as FSP doesn't have the support. only FSP way fully or coreboot way fully.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36450 )
Change subject: mb/intel/saddlebrook: Select coreboot MP init ......................................................................
Patch Set 1: Code-Review+2
Can we probably fix our MP init that it works again?
It's the FSP path that seems broken. I'll propose a patch to remove it.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36450 )
Change subject: mb/intel/saddlebrook: Select coreboot MP init ......................................................................
Patch Set 1:
Can we probably fix our MP init that it works again?
It's the FSP path that seems broken. I'll propose a patch to remove it.
Actually, it's just a minor option, and also enabled for apollolake/ and cannonlake/. Not worth the Kconfig complexity to hide it for skylake/ only. I wouldn't oppose to remove it entirely, but expect there are down- stream requirements for CNL/CFL/CML?
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36450 )
Change subject: mb/intel/saddlebrook: Select coreboot MP init ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36450/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36450/1//COMMIT_MSG@12 PS1, Line 12: linux Which version?
Hello Subrata Banik, Arthur Heymans, Michael Niewöhner, Teo Boon Tiong, build bot (Jenkins), Nico Huber, Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36450
to look at the new patch set (#2).
Change subject: mb/intel/saddlebrook: Select coreboot MP init ......................................................................
mb/intel/saddlebrook: Select coreboot MP init
use coreboot MP init for saddlebrook by default.
BUG=None TEST=Boot till yocto linux 2.7 on saddlebrook and verified the AP's proper initialization using 'cat /proc/cpuinfo' command.
Change-Id: I2db2fe92c8ba0e649dccf95ce804a97ae4a05603 Signed-off-by: Praveen Hodagatta Pranesh praveenx.hodagatta.pranesh@intel.com --- M src/mainboard/intel/saddlebrook/Kconfig 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/36450/2
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36450 )
Change subject: mb/intel/saddlebrook: Select coreboot MP init ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36450/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36450/1//COMMIT_MSG@12 PS1, Line 12: linux
Which version?
Done
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36450 )
Change subject: mb/intel/saddlebrook: Select coreboot MP init ......................................................................
mb/intel/saddlebrook: Select coreboot MP init
use coreboot MP init for saddlebrook by default.
BUG=None TEST=Boot till yocto linux 2.7 on saddlebrook and verified the AP's proper initialization using 'cat /proc/cpuinfo' command.
Change-Id: I2db2fe92c8ba0e649dccf95ce804a97ae4a05603 Signed-off-by: Praveen Hodagatta Pranesh praveenx.hodagatta.pranesh@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/36450 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Arthur Heymans arthur@aheymans.xyz Reviewed-by: Michael Niewöhner Reviewed-by: Nico Huber nico.h@gmx.de --- M src/mainboard/intel/saddlebrook/Kconfig 1 file changed, 0 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved Arthur Heymans: Looks good to me, but someone else must approve Michael Niewöhner: Looks good to me, but someone else must approve
diff --git a/src/mainboard/intel/saddlebrook/Kconfig b/src/mainboard/intel/saddlebrook/Kconfig index cd18541..315104e 100644 --- a/src/mainboard/intel/saddlebrook/Kconfig +++ b/src/mainboard/intel/saddlebrook/Kconfig @@ -30,7 +30,6 @@ select SUPERIO_NUVOTON_NCT6776_COM_A select HAVE_CMOS_DEFAULT select MAINBOARD_USES_IFD_GBE_REGION - select USE_INTEL_FSP_MP_INIT
config IRQ_SLOT_COUNT int
-
Arthur Heymans (Code Review) -
Michael Niewöhner (Code Review)
-
Nico Huber (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)
-
Philipp Deppenwiese (Code Review)
-
PraveenX Hodagatta Pranesh (Code Review)
-
Subrata Banik (Code Review)