Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/20476 )
Change subject: [WIP]: mainboard/google/soraka: wacom touchscreen support ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/#/c/20476/1/src/mainboard/google/poppy/variants/... File src/mainboard/google/poppy/variants/baseboard/gpio.c:
https://review.coreboot.org/#/c/20476/1/src/mainboard/google/poppy/variants/... PS1, Line 237: 1 Why take the device out of reset here? It should be taken care of by the ACPI power resource.
https://review.coreboot.org/#/c/20476/1/src/mainboard/google/poppy/variants/... File src/mainboard/google/poppy/variants/soraka/devicetree.cb:
https://review.coreboot.org/#/c/20476/1/src/mainboard/google/poppy/variants/... PS1, Line 217: : : : : : : : : : I don't think we should get rid of this node right away. Older proto boards would still be using this.
https://review.coreboot.org/#/c/20476/1/src/mainboard/google/poppy/variants/... PS1, Line 218: WCOMNTN2 Is this supposed to be WCOM50C1?
https://review.coreboot.org/#/c/20476/1/src/mainboard/google/poppy/variants/... PS1, Line 223: " As per datasheet, this should be at least 100ms.
-
Furquan Shaikh (Code Review)