Change in coreboot[master]: src/vendorcode/amd/fsp/picasso: Add HDMI 2.0 diable setting section o...
Attention is currently required from: Jason Glenesk, Raul Rangel, Martin Roth, Marshall Dawson, Chris Wang, Felix Held. Patrick Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52544 )
Change subject: src/vendorcode/amd/fsp/picasso: Add HDMI 2.0 diable setting section of FspmUpd.h ......................................................................
Patch Set 4:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/52544/comment/89ea7824_de07fb53 PS3, Line 7: diable
disable
yes, their is a token to disable HDMI 2.0 feature
https://review.coreboot.org/c/coreboot/+/52544/comment/1f843f69_128a5dcb PS3, Line 9: for customized project
I'd remove this - it doesn't matter what project it's for since it's going into generic code.
got it, already remove it
https://review.coreboot.org/c/coreboot/+/52544/comment/b2d08b02_cde55c87 PS3, Line 13: system integrated table
to the FSP?
yes, will update in fspmpcdinit
File src/vendorcode/amd/fsp/picasso/FspmUpd.h:
https://review.coreboot.org/c/coreboot/+/52544/comment/60061e48_e5239b0d PS3, Line 67: UnusedUpdSpace1;
Felix: Why is this left as "unused"? Shouldn't this have been updated in a previous patch? It look […]
correct, also need to update the "unused"definition to sync Matt's commit?
-
Patrick Huang (Code Review)