Change in coreboot[master]: soc/intel/common/block: Move smihandler common functions into common ...
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/26138 )
Change subject: soc/intel/common/block: Move smihandler common functions into common code ......................................................................
Patch Set 42:
(3 comments)
https://review.coreboot.org/c/coreboot/+/26138/41/src/soc/intel/common/block... File src/soc/intel/common/block/smm/smihandler.c:
https://review.coreboot.org/c/coreboot/+/26138/41/src/soc/intel/common/block... PS41, Line 67: __weak
Why is this still kept weak? None of the SoCs provide their own implementation after this change.
Done
https://review.coreboot.org/c/coreboot/+/26138/41/src/soc/intel/common/block... PS41, Line 70: tco_sts
looks same to me. […]
@Furquan, let me know if you have some further opens
marking resolved based on register details been shared
https://review.coreboot.org/c/coreboot/+/26138/41/src/soc/intel/common/block... PS41, Line 499:
isn't this fixed at latest patch set ?
Ack
-
Subrata Banik (Code Review)