Meera Ravindranath has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38273 )
Change subject: mb/intel/jasperlake_rvp: Update FMAP for jslrvp ......................................................................
mb/intel/jasperlake_rvp: Update FMAP for jslrvp
Remove unused SMM_STORE space and use it for RW_LEGACY area
BUG=None TEST=None
Change-Id: I5724b860271025e8cb8b320ecbd33352ef779660 Signed-off-by: Meera Ravindranath meera.ravindranath@intel.com --- M src/mainboard/intel/jasperlake_rvp/chromeos.fmd 1 file changed, 4 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/38273/1
diff --git a/src/mainboard/intel/jasperlake_rvp/chromeos.fmd b/src/mainboard/intel/jasperlake_rvp/chromeos.fmd index f4db8b4..5f4f362 100644 --- a/src/mainboard/intel/jasperlake_rvp/chromeos.fmd +++ b/src/mainboard/intel/jasperlake_rvp/chromeos.fmd @@ -28,16 +28,15 @@ RW_VPD(PRESERVE)@0x28000 0x2000 RW_NVRAM(PRESERVE)@0x2a000 0x6000 } - SMMSTORE(PRESERVE)@0x5d0000 0x40000 - RW_LEGACY(CBFS)@0x610000 0x1c0000 - WP_RO@0x7d0000 0x430000 { + RW_LEGACY(CBFS)@0x5d0000 0x100000 + WP_RO@0x6d0000 0x330000 { RO_VPD(PRESERVE)@0x0 0x4000 - RO_SECTION@0x4000 0x42c000 { + RO_SECTION@0x4000 0x32c000 { FMAP@0x0 0x800 RO_FRID@0x800 0x40 RO_FRID_PAD@0x840 0x7c0 GBB@0x1000 0xef000 - COREBOOT(CBFS)@0xf0000 0x33c000 + COREBOOT(CBFS)@0xf0000 0x23c000 } } }
Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38273 )
Change subject: mb/intel/jasperlake_rvp: Update FMAP for jslrvp ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38273/1/src/mainboard/intel/jasperl... File src/mainboard/intel/jasperlake_rvp/chromeos.fmd:
https://review.coreboot.org/c/coreboot/+/38273/1/src/mainboard/intel/jasperl... PS1, Line 7: 0x400000 needs be to be re-aligned.
https://review.coreboot.org/c/coreboot/+/38273/1/src/mainboard/intel/jasperl... PS1, Line 7: 0xC00000 needs to be updated as well.
Justin TerAvest has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38273 )
Change subject: mb/intel/jasperlake_rvp: Update FMAP for jslrvp ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38273/1/src/mainboard/intel/jasperl... File src/mainboard/intel/jasperlake_rvp/chromeos.fmd:
https://review.coreboot.org/c/coreboot/+/38273/1/src/mainboard/intel/jasperl... PS1, Line 7: 0xC00000
needs to be updated as well.
Aamir, are we waiting for Intel to make changes here? Not sure what the next action is.
Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38273 )
Change subject: mb/intel/jasperlake_rvp: Update FMAP for jslrvp ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38273/1/src/mainboard/intel/jasperl... File src/mainboard/intel/jasperlake_rvp/chromeos.fmd:
https://review.coreboot.org/c/coreboot/+/38273/1/src/mainboard/intel/jasperl... PS1, Line 7: 0xC00000
Aamir, are we waiting for Intel to make changes here? Not sure what the next action is.
yes Justin, the SI_BIOS size needs to be 10MB, will update the changes.
Hello build bot (Jenkins), Maulik V Vaghela, Rizwan Qureshi, Aamir Bohra, Ronak Kanabar,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/38273
to look at the new patch set (#2).
Change subject: mb/intel/jasperlake_rvp: Update FMAP for jslrvp ......................................................................
mb/intel/jasperlake_rvp: Update FMAP for jslrvp
Remove unused SMM_STORE space and use it for RW_LEGACY area
BUG=None TEST=None
Change-Id: I5724b860271025e8cb8b320ecbd33352ef779660 Signed-off-by: Meera Ravindranath meera.ravindranath@intel.com Signed-off-by: Ronak Kanabar ronak.kanabar@intel.com --- M src/mainboard/intel/jasperlake_rvp/chromeos.fmd 1 file changed, 7 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/38273/2
Meera Ravindranath has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38273 )
Change subject: mb/intel/jasperlake_rvp: Update FMAP for jslrvp ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38273/1/src/mainboard/intel/jasperl... File src/mainboard/intel/jasperlake_rvp/chromeos.fmd:
https://review.coreboot.org/c/coreboot/+/38273/1/src/mainboard/intel/jasperl... PS1, Line 7: 0xC00000
yes Justin, the SI_BIOS size needs to be 10MB, will update the changes.
Done
https://review.coreboot.org/c/coreboot/+/38273/1/src/mainboard/intel/jasperl... PS1, Line 7: 0x400000
needs be to be re-aligned.
Done
Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38273 )
Change subject: mb/intel/jasperlake_rvp: Update FMAP for jslrvp ......................................................................
Patch Set 4: Code-Review+2
V Sowmya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38273 )
Change subject: mb/intel/jasperlake_rvp: Update FMAP for jslrvp ......................................................................
Patch Set 4: Code-Review+2
Ronak Kanabar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38273 )
Change subject: mb/intel/jasperlake_rvp: Update FMAP for jslrvp ......................................................................
Patch Set 4: Code-Review+2
Ronak Kanabar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38273 )
Change subject: mb/intel/jasperlake_rvp: Update FMAP for jslrvp ......................................................................
Patch Set 4: -Code-Review
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38273 )
Change subject: mb/intel/jasperlake_rvp: Update FMAP for jslrvp ......................................................................
mb/intel/jasperlake_rvp: Update FMAP for jslrvp
Remove unused SMM_STORE space and use it for RW_LEGACY area
BUG=None TEST=None
Change-Id: I5724b860271025e8cb8b320ecbd33352ef779660 Signed-off-by: Meera Ravindranath meera.ravindranath@intel.com Signed-off-by: Ronak Kanabar ronak.kanabar@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/38273 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Maulik V Vaghela maulik.v.vaghela@intel.com Reviewed-by: V Sowmya v.sowmya@intel.com --- M src/mainboard/intel/jasperlake_rvp/chromeos.fmd 1 file changed, 7 insertions(+), 8 deletions(-)
Approvals: build bot (Jenkins): Verified V Sowmya: Looks good to me, approved Maulik V Vaghela: Looks good to me, approved
diff --git a/src/mainboard/intel/jasperlake_rvp/chromeos.fmd b/src/mainboard/intel/jasperlake_rvp/chromeos.fmd index f4db8b4..827e448 100644 --- a/src/mainboard/intel/jasperlake_rvp/chromeos.fmd +++ b/src/mainboard/intel/jasperlake_rvp/chromeos.fmd @@ -1,10 +1,10 @@ FLASH@0xff000000 0x1000000 { - SI_ALL@0x0 0x3F0000 { + SI_ALL@0x0 0x600000 { SI_DESC@0x0 0x1000 SI_EC@0x1000 0x80000 - SI_ME@0x81000 0x36F000 + SI_ME@0x81000 0x57F000 } - SI_BIOS@0x400000 0xC00000 { + SI_BIOS@0x600000 0xA00000 { RW_SECTION_A@0x0 0x2d0000 { VBLOCK_A@0x0 0x10000 FW_MAIN_A(CBFS)@0x10000 0x2bffc0 @@ -28,16 +28,15 @@ RW_VPD(PRESERVE)@0x28000 0x2000 RW_NVRAM(PRESERVE)@0x2a000 0x6000 } - SMMSTORE(PRESERVE)@0x5d0000 0x40000 - RW_LEGACY(CBFS)@0x610000 0x1c0000 - WP_RO@0x7d0000 0x430000 { + RW_LEGACY(CBFS)@0x5d0000 0x100000 + WP_RO@0x6d0000 0x330000 { RO_VPD(PRESERVE)@0x0 0x4000 - RO_SECTION@0x4000 0x42c000 { + RO_SECTION@0x4000 0x32c000 { FMAP@0x0 0x800 RO_FRID@0x800 0x40 RO_FRID_PAD@0x840 0x7c0 GBB@0x1000 0xef000 - COREBOOT(CBFS)@0xf0000 0x33c000 + COREBOOT(CBFS)@0xf0000 0x23c000 } } }
-
Aamir Bohra (Code Review) -
Justin TerAvest (Code Review)
-
Maulik V Vaghela (Code Review)
-
Meera Ravindranath (Code Review)
-
Patrick Georgi (Code Review)
-
Ronak Kanabar (Code Review)
-
V Sowmya (Code Review)