Attention is currently required from: Martin Roth, Felix Held. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51675 )
Change subject: mb/google/guybrush: Update GPIO configuration ......................................................................
Patch Set 10: Code-Review+1
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/51675/comment/51e6b122_1c76ac52 PS10, Line 9: Init I2C3 early for GSC communication. This isn't done as part of this CL.
File src/mainboard/google/guybrush/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/51675/comment/77703c98_7048a4e1 PS10, Line 59: // PAD_NF(GPIO_26, PCIE_RST_L, PULL_NONE), I think it's best not to leave commented out code here. Whenever required, it should be easy to add it back in.
https://review.coreboot.org/c/coreboot/+/51675/comment/43a8c992_a2deb5ae PS10, Line 180: SPI_CLK2 nit: Probably name this ESPI_SOC_CLK? That will make it clear that this is related to eSPI clock.
-
Furquan Shaikh (Code Review)