Attention is currently required from: Martin Roth, Felix Held.
Patch set 10:Code-Review +1
3 comments:
Commit Message:
Patch Set #10, Line 9: Init I2C3 early for GSC communication.
This isn't done as part of this CL.
File src/mainboard/google/guybrush/variants/baseboard/gpio.c:
Patch Set #10, Line 59: // PAD_NF(GPIO_26, PCIE_RST_L, PULL_NONE),
I think it's best not to leave commented out code here. Whenever required, it should be easy to add it back in.
Patch Set #10, Line 180: SPI_CLK2
nit: Probably name this ESPI_SOC_CLK? That will make it clear that this is related to eSPI clock.
To view, visit change 51675. To unsubscribe, or for help writing mail filters, visit settings.