Attention is currently required from: Hung-Te Lin, Paul Menzel, Arthur Heymans, Wenbin Mei.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51966 )
Change subject: soc/mediatek: add new driver 'msdc' for eMMC
......................................................................
Patch Set 9:
(2 comments)
File src/soc/mediatek/common/include/soc/msdc.h:
https://review.coreboot.org/c/coreboot/+/51966/comment/25ebd24e_f84657f1
PS9, Line 11:
Use tabs for alignment?
https://review.coreboot.org/c/coreboot/+/51966/comment/3fa44dcc_b8a0bb74
PS9, Line 158: s
S
Same for other fields.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51966
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I54a7749ed167c00cd631a76af7c67c654c7bc725
Gerrit-Change-Number: 51966
Gerrit-PatchSet: 9
Gerrit-Owner: Wenbin Mei
wenbin.mei@mediatek.corp-partner.google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Xi Chen
xixi.chen@mediatek.com
Gerrit-Reviewer: Yidi Lin
yidi.lin@mediatek.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Wenbin Mei
wenbin.mei@mediatek.corp-partner.google.com
Gerrit-Comment-Date: Thu, 08 Apr 2021 02:44:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment