Ping-chung Chen has posted comments on this change. ( https://review.coreboot.org/27350 )
Change subject: mb/google/atlas: MIPI camera ASL files for Atlas ......................................................................
Patch Set 7:
(3 comments)
https://review.coreboot.org/#/c/27350/5/src/mainboard/google/poppy/variants/... File src/mainboard/google/poppy/variants/atlas/include/variant/acpi/mipi_camera.asl:
https://review.coreboot.org/#/c/27350/5/src/mainboard/google/poppy/variants/... PS5, Line 32: :
Tab needed
Done
https://review.coreboot.org/#/c/27350/5/src/mainboard/google/poppy/variants/... PS5, Line 62:
FCPR naming convention is used to refer that it'a front camera. […]
This is front camera.
https://review.coreboot.org/#/c/27350/5/src/mainboard/google/poppy/variants/... PS5, Line 123:
I don't believe SSDB is currently used. Please remove.
Done
-
Ping-chung Chen (Code Review)