Change in coreboot[master]: device/resource_allocator_v4: Change BIOS_SPEW to BIOS_DEBUG

[Furquan Shaikh (Code Review)]

Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41477 )

Change subject: device/resource_allocator_v4: Change BIOS_SPEW to BIOS_DEBUG
......................................................................

device/resource_allocator_v4: Change BIOS_SPEW to BIOS_DEBUG

This change updates the log level for prints in resource allocator v4
to BIOS_DEBUG instead of BIOS_SPEW. These are critical in debugging
issues and should be enabled at log level BIOS_DEBUG.

Signed-off-by: Furquan Shaikh 
Change-Id: Ib863619f5e1214e4fe6f05c52be6fa2de36e6c3b
---
M src/device/resource_allocator_v4.c
1 file changed, 8 insertions(+), 8 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/41477/1

diff --git a/src/device/resource_allocator_v4.c b/src/device/resource_allocator_v4.c
index 3f278c9..916f3b8 100644
--- a/src/device/resource_allocator_v4.c
+++ b/src/device/resource_allocator_v4.c
@@ -67,7 +67,7 @@
     */
    base = 0;

-	printk(BIOS_SPEW, "%s %s: size: %llx align: %d gran: %d limit: %llx\n",
+	printk(BIOS_DEBUG, "%s %s: size: %llx align: %d gran: %d limit: %llx\n",
           dev_path(bridge), resource2str(bridge_res), bridge_res->size,
           bridge_res->align, bridge_res->gran, bridge_res->limit);

@@ -122,7 +122,7 @@
    	 */
    	base = round(base, child_res->align);

-		printk(BIOS_SPEW, "%s %02lx *  [0x%llx - 0x%llx] %s\n",
+		printk(BIOS_DEBUG, "%s %02lx *  [0x%llx - 0x%llx] %s\n",
    	       dev_path(child), child_res->index, base, base + child_res->size - 1,
    	       resource2str(child_res));

@@ -137,7 +137,7 @@
     */
    bridge_res->size = round(base, bridge_res->gran);

-	printk(BIOS_SPEW, "%s %s: size: %llx align: %d gran: %d limit: %llx done\n",
+	printk(BIOS_DEBUG, "%s %s: size: %llx align: %d gran: %d limit: %llx done\n",
           dev_path(bridge), resource2str(bridge_res), bridge_res->size,
           bridge_res->align, bridge_res->gran, bridge_res->limit);
 }
@@ -363,7 +363,7 @@
    	if (memranges_steal(ranges, resource->limit, resource->size, resource->align,
    			    type_match, &resource->base) == false) {
    		printk(BIOS_ERR, "ERROR: Resource didn't fit!!! ");
-			printk(BIOS_SPEW, "%s %02lx *  size: 0x%llx limit: %llx %s\n",
+			printk(BIOS_DEBUG, "%s %02lx *  size: 0x%llx limit: %llx %s\n",
    		       dev_path(dev), resource->index,
    		       resource->size, resource->limit, resource2str(resource));
    		mark_resource_invalid(resource);
@@ -373,7 +373,7 @@
    	resource->limit = resource->base + resource->size - 1;
    	resource->flags |= IORESOURCE_ASSIGNED;

-		printk(BIOS_SPEW, "%s %02lx *  [0x%llx - 0x%llx] limit: %llx %s\n",
+		printk(BIOS_DEBUG, "%s %02lx *  [0x%llx - 0x%llx] limit: %llx %s\n",
    	       dev_path(dev), resource->index, resource->base,
    	       resource->size ? resource->base + resource->size - 1 :
    	       resource->base, resource->limit, resource2str(resource));
@@ -386,7 +386,7 @@
    if (!res->size)
    	return;

-	printk(BIOS_SPEW, "%s: %s %02lx base %08llx limit %08llx %s (fixed)\n",
+	printk(BIOS_DEBUG, "%s: %s %02lx base %08llx limit %08llx %s (fixed)\n",
           __func__, dev_path(dev), res->index, res->base,
           res->base + res->size - 1, resource2str(res));

@@ -459,7 +459,7 @@
 static void setup_resource_ranges(const struct device *dev, const struct resource *res,
    			  unsigned long type, struct memranges *ranges)
 {
-	printk(BIOS_SPEW, "%s %s: base: %llx size: %llx align: %d gran: %d limit: %llx\n",
+	printk(BIOS_DEBUG, "%s %s: base: %llx size: %llx align: %d gran: %d limit: %llx\n",
           dev_path(dev), resource2str(res), res->base, res->size, res->align,
           res->gran, res->limit);

@@ -477,7 +477,7 @@
    			    const struct resource *res)
 {
    memranges_teardown(ranges);
-	printk(BIOS_SPEW, "%s %s: base: %llx size: %llx align: %d gran: %d limit: %llx done\n",
+	printk(BIOS_DEBUG, "%s %s: base: %llx size: %llx align: %d gran: %d limit: %llx done\n",
           dev_path(dev), resource2str(res), res->base, res->size, res->align,
           res->gran, res->limit);
 }

[Furquan Shaikh (Code Review)]

Furquan Shaikh has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/41477 )

Change subject: device/resource_allocator_v4: Change BIOS_SPEW to BIOS_DEBUG
......................................................................

device/resource_allocator_v4: Change BIOS_SPEW to BIOS_DEBUG

This change updates the log level for prints in resource allocator v4
to BIOS_DEBUG instead of BIOS_SPEW. These are critical in debugging
issues and should be enabled at log level BIOS_DEBUG.

Signed-off-by: Furquan Shaikh 
Change-Id: Ib863619f5e1214e4fe6f05c52be6fa2de36e6c3b
---
M src/device/resource_allocator_v4.c
1 file changed, 8 insertions(+), 8 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/41477/2

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41477 )

Change subject: device/resource_allocator_v4: Change BIOS_SPEW to BIOS_DEBUG
......................................................................

Patch Set 3: Code-Review+1

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41477 )

Change subject: device/resource_allocator_v4: Change BIOS_SPEW to BIOS_DEBUG
......................................................................

Patch Set 3: Code-Review+1

How about adding an option to enable debug just for the allocator prints?

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41477 )

Change subject: device/resource_allocator_v4: Change BIOS_SPEW to BIOS_DEBUG
......................................................................

Patch Set 4: Code-Review+2

[Aaron Durbin (Code Review)]

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41477 )

Change subject: device/resource_allocator_v4: Change BIOS_SPEW to BIOS_DEBUG
......................................................................

Patch Set 4: Code-Review+2

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41477 )

Change subject: device/resource_allocator_v4: Change BIOS_SPEW to BIOS_DEBUG
......................................................................

device/resource_allocator_v4: Change BIOS_SPEW to BIOS_DEBUG

This change updates the log level for prints in resource allocator v4
to BIOS_DEBUG instead of BIOS_SPEW. These are critical in debugging
issues and should be enabled at log level BIOS_DEBUG.

Signed-off-by: Furquan Shaikh 
Change-Id: Ib863619f5e1214e4fe6f05c52be6fa2de36e6c3b
Reviewed-on: https://review.coreboot.org/c/coreboot/+/41477
Reviewed-by: HAOUAS Elyes 
Reviewed-by: Aaron Durbin 
Reviewed-by: Paul Menzel 
Reviewed-by: Angel Pons 
Tested-by: build bot (Jenkins) 
---
M src/device/resource_allocator_v4.c
1 file changed, 8 insertions(+), 8 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Paul Menzel: Looks good to me, but someone else must approve
  Aaron Durbin: Looks good to me, approved
  HAOUAS Elyes: Looks good to me, approved
  Angel Pons: Looks good to me, but someone else must approve

diff --git a/src/device/resource_allocator_v4.c b/src/device/resource_allocator_v4.c
index ae3c764..75e8392 100644
--- a/src/device/resource_allocator_v4.c
+++ b/src/device/resource_allocator_v4.c
@@ -67,7 +67,7 @@
     */
    base = 0;

-	printk(BIOS_SPEW, "%s %s: size: %llx align: %d gran: %d limit: %llx\n",
+	printk(BIOS_DEBUG, "%s %s: size: %llx align: %d gran: %d limit: %llx\n",
           dev_path(bridge), resource2str(bridge_res), bridge_res->size,
           bridge_res->align, bridge_res->gran, bridge_res->limit);

@@ -122,7 +122,7 @@
    	 */
    	base = round(base, child_res->align);

-		printk(BIOS_SPEW, "%s %02lx *  [0x%llx - 0x%llx] %s\n",
+		printk(BIOS_DEBUG, "%s %02lx *  [0x%llx - 0x%llx] %s\n",
    	       dev_path(child), child_res->index, base, base + child_res->size - 1,
    	       resource2str(child_res));

@@ -137,7 +137,7 @@
     */
    bridge_res->size = round(base, bridge_res->gran);

-	printk(BIOS_SPEW, "%s %s: size: %llx align: %d gran: %d limit: %llx done\n",
+	printk(BIOS_DEBUG, "%s %s: size: %llx align: %d gran: %d limit: %llx done\n",
           dev_path(bridge), resource2str(bridge_res), bridge_res->size,
           bridge_res->align, bridge_res->gran, bridge_res->limit);
 }
@@ -371,7 +371,7 @@
    	if (memranges_steal(ranges, resource->limit, resource->size, resource->align,
    			    type_match, &resource->base) == false) {
    		printk(BIOS_ERR, "ERROR: Resource didn't fit!!! ");
-			printk(BIOS_SPEW, "%s %02lx *  size: 0x%llx limit: %llx %s\n",
+			printk(BIOS_DEBUG, "%s %02lx *  size: 0x%llx limit: %llx %s\n",
    		       dev_path(dev), resource->index,
    		       resource->size, resource->limit, resource2str(resource));
    		continue;
@@ -380,7 +380,7 @@
    	resource->limit = resource->base + resource->size - 1;
    	resource->flags |= IORESOURCE_ASSIGNED;

-		printk(BIOS_SPEW, "%s %02lx *  [0x%llx - 0x%llx] limit: %llx %s\n",
+		printk(BIOS_DEBUG, "%s %02lx *  [0x%llx - 0x%llx] limit: %llx %s\n",
    	       dev_path(dev), resource->index, resource->base,
    	       resource->size ? resource->base + resource->size - 1 :
    	       resource->base, resource->limit, resource2str(resource));
@@ -393,7 +393,7 @@
    if (!res->size)
    	return;

-	printk(BIOS_SPEW, "%s: %s %02lx base %08llx limit %08llx %s (fixed)\n",
+	printk(BIOS_DEBUG, "%s: %s %02lx base %08llx limit %08llx %s (fixed)\n",
           __func__, dev_path(dev), res->index, res->base,
           res->base + res->size - 1, resource2str(res));

@@ -466,7 +466,7 @@
 static void setup_resource_ranges(const struct device *dev, const struct resource *res,
    			  unsigned long type, struct memranges *ranges)
 {
-	printk(BIOS_SPEW, "%s %s: base: %llx size: %llx align: %d gran: %d limit: %llx\n",
+	printk(BIOS_DEBUG, "%s %s: base: %llx size: %llx align: %d gran: %d limit: %llx\n",
           dev_path(dev), resource2str(res), res->base, res->size, res->align,
           res->gran, res->limit);

@@ -484,7 +484,7 @@
    			    const struct resource *res)
 {
    memranges_teardown(ranges);
-	printk(BIOS_SPEW, "%s %s: base: %llx size: %llx align: %d gran: %d limit: %llx done\n",
+	printk(BIOS_DEBUG, "%s %s: base: %llx size: %llx align: %d gran: %d limit: %llx done\n",
           dev_path(dev), resource2str(res), res->base, res->size, res->align,
           res->gran, res->limit);
 }