Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46354 )
Change subject: include/cpu/x86: introduce new helper fors (un)setting MSRs ......................................................................
Patch Set 5:
(5 comments)
https://review.coreboot.org/c/coreboot/+/46354/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46354/3//COMMIT_MSG@10 PS3, Line 10: MRS
MSR
Done
https://review.coreboot.org/c/coreboot/+/46354/3//COMMIT_MSG@12 PS3, Line 12: CB:42134
sounds good
Done
https://review.coreboot.org/c/coreboot/+/46354/3/src/cpu/intel/haswell/final... File src/cpu/intel/haswell/finalize.c:
https://review.coreboot.org/c/coreboot/+/46354/3/src/cpu/intel/haswell/final... PS3, Line 10: (1 << 0)
nit: we should use the BIT macro (types. […]
done
https://review.coreboot.org/c/coreboot/+/46354/3/src/include/cpu/x86/msr.h File src/include/cpu/x86/msr.h:
https://review.coreboot.org/c/coreboot/+/46354/3/src/include/cpu/x86/msr.h@3... PS3, Line 319: }
We could also add an msr_set(reg, set) shorthand for the `unset == 0` case.
done. added msr_set and msr_unset
https://review.coreboot.org/c/coreboot/+/46354/3/src/soc/intel/common/block/... File src/soc/intel/common/block/include/intelblocks/msr.h:
https://review.coreboot.org/c/coreboot/+/46354/3/src/soc/intel/common/block/... PS3, Line 59: _BIT
nit, I'd drop the _BIT suffix
done
-
Michael Niewöhner (Code Review)