Attention is currently required from: Kyösti Mälkki, Patrick Rudolph.
Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55182 )
Change subject: soc/intel/common: Fix X2APIC NMI entry in ACPI MADT
......................................................................
Patch Set 1:
(1 comment)
File src/soc/intel/common/block/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/55182/comment/f4be5af7_6813e2f0
PS1, Line 86: 0xffffffff, 0xd, 1);
Thanks for finding out the this. Do you have detail failure from original code? […]
if (is_x2apic_mode())
current += acpi_create_madt_lx2apic_nmi((acpi_madt_lx2apic_nmi_t *)current,
0xffffffff, 0xd, 1);
else
current += acpi_create_madt_lapic_nmi((acpi_madt_lapic_nmi_t *)current, 0xff, 5, 1);
This logic is working fine. Can you also check it from your side?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55182
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9c0537a3efba942329f80d7cfdbd910b8958516f
Gerrit-Change-Number: 55182
Gerrit-PatchSet: 1
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Sat, 05 Jun 2021 03:15:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Wonkyu Kim
wonkyu.kim@intel.com
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment