Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/58771 )
Change subject: amd/i2c: Remove the weak function ......................................................................
amd/i2c: Remove the weak function
BUG=b:140165023
Change-Id: Ieedd6c9f3abeed9839892e5d07127862cd47d57f Signed-off-by: Zheng Bao fishbaozi@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/58771 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Felix Held felix-coreboot@felixheld.de --- M src/soc/amd/common/block/i2c/i2c.c M src/soc/amd/stoneyridge/i2c.c 2 files changed, 6 insertions(+), 5 deletions(-)
Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, approved
diff --git a/src/soc/amd/common/block/i2c/i2c.c b/src/soc/amd/common/block/i2c/i2c.c index ff9ec90..d2e0473 100644 --- a/src/soc/amd/common/block/i2c/i2c.c +++ b/src/soc/amd/common/block/i2c/i2c.c @@ -78,11 +78,6 @@ return -1; }
-void __weak soc_i2c_misc_init(unsigned int bus, const struct dw_i2c_bus_config *cfg) -{ - /* Nothing by default. */ -} - static void dw_i2c_soc_init(bool is_early_init) { unsigned int bus; diff --git a/src/soc/amd/stoneyridge/i2c.c b/src/soc/amd/stoneyridge/i2c.c index 6a6d776..e589b04 100644 --- a/src/soc/amd/stoneyridge/i2c.c +++ b/src/soc/amd/stoneyridge/i2c.c @@ -5,6 +5,7 @@ #include <soc/iomap.h> #include <soc/i2c.h> #include "chip.h" +#include <drivers/i2c/designware/dw_i2c.h>
static const struct soc_i2c_ctrlr_info i2c_ctrlr[] = { { I2C_MASTER_MODE, APU_I2C0_BASE, "I2CA" }, @@ -26,3 +27,8 @@ *num_buses = ARRAY_SIZE(config->i2c); return config->i2c; } + +void soc_i2c_misc_init(unsigned int bus, const struct dw_i2c_bus_config *cfg) +{ + /* Do nothing. */ +}