Attention is currently required from: Andrey Pronin, Aaron Durbin. Aseda Aboagye has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52920 )
Change subject: mb/google/dedede: Select TPM20_CREATE_FWMP for discrete TPM boards ......................................................................
Patch Set 5:
(1 comment)
File src/mainboard/google/dedede/Kconfig:
https://review.coreboot.org/c/coreboot/+/52920/comment/76599c64_33155b5c PS1, Line 167: select TPM20_CREATE_FWMP
Doesn't this selection need to be under another config? Basically move this to line 41 or 42. […]
Ah, thanks for the correction. That might explain why it didn't seem like my changes were being built. (still a Kconfig noob)
&& I believe Andrey would prefer to have this as a config option for now.