Attention is currently required from: Yu-Ping Wu.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79956?usp=email )
Change subject: libpayload/vboot/Makefile.inc: Pass FIRMWARE_ARCH=mock if LP_ARCH_MOCK
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
File payloads/libpayload/vboot/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/79956/comment/25b0fb9c_3f6b9a7d :
PS2, Line 22: VBOOT_FIRMWARE_ARCH := mock
nit: would be a bit easier to just say `VBOOT_FIRMWARE_ARCH-y := mock` here?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79956?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9ead7f2f93eac5f5c3887074423fb9aa50a489c0
Gerrit-Change-Number: 79956
Gerrit-PatchSet: 2
Gerrit-Owner: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Tue, 16 Jan 2024 18:51:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment