Change in coreboot[master]: mediatek/mt8183: Overlap verstage and romstage in memory layout
Tristan Hsieh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34871 )
Change subject: mediatek/mt8183: Overlap verstage and romstage in memory layout ......................................................................
mediatek/mt8183: Overlap verstage and romstage in memory layout
Since SRAM space is too small to fit all needed features, enable VBOOT_RETURN_FROM_VERSTAGE and overlap verstage and romstage to gain more space.
BUG=b:134351649 BRANCH=none TEST=emerge-kukui coreboot
Change-Id: Ibe336cf93b01fa2ea57b4c2e0a89685424878c91 Signed-off-by: Tristan Shieh tristan.shieh@mediatek.com --- M src/soc/mediatek/mt8183/Kconfig M src/soc/mediatek/mt8183/include/soc/memlayout.ld 2 files changed, 4 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/34871/1
diff --git a/src/soc/mediatek/mt8183/Kconfig b/src/soc/mediatek/mt8183/Kconfig index c60cdea..9ac57bd 100644 --- a/src/soc/mediatek/mt8183/Kconfig +++ b/src/soc/mediatek/mt8183/Kconfig @@ -15,6 +15,7 @@ select VBOOT_MUST_REQUEST_DISPLAY select VBOOT_STARTS_IN_BOOTBLOCK select VBOOT_SEPARATE_VERSTAGE + select VBOOT_RETURN_FROM_VERSTAGE
config DEBUG_DRAM bool "Output verbose DRAM related debug messages" diff --git a/src/soc/mediatek/mt8183/include/soc/memlayout.ld b/src/soc/mediatek/mt8183/include/soc/memlayout.ld index 6a11a0e..7da282e 100644 --- a/src/soc/mediatek/mt8183/include/soc/memlayout.ld +++ b/src/soc/mediatek/mt8183/include/soc/memlayout.ld @@ -40,9 +40,9 @@ SRAM_END(0x00120000)
SRAM_L2C_START(0x00200000) - OVERLAP_DECOMPRESSOR_ROMSTAGE(0x000201000, 152K) - BOOTBLOCK(0x00227000, 89K) - VERSTAGE(0x0023E000, 114K) + DECOMPRESSOR(0x00201000, 28K) + BOOTBLOCK(0x00208000, 64K) + OVERLAP_VERSTAGE_ROMSTAGE(0x00218000, 160K) SRAM_L2C_END(0x00280000)
DRAM_START(0x40000000)
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34871 )
Change subject: mediatek/mt8183: Overlap verstage and romstage in memory layout ......................................................................
Patch Set 1: Code-Review+2
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34871 )
Change subject: mediatek/mt8183: Overlap verstage and romstage in memory layout ......................................................................
Patch Set 1: Code-Review+2
Note that there's also an OVERLAP_DECOMPRESSOR_VERSTAGE_ROMSTAGE() if you want to overlap all the things. ;)
Hello Julius Werner, Hung-Te Lin, Huayang Duan, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34871
to look at the new patch set (#2).
Change subject: mediatek/mt8183: Overlap decompressor, verstage and romstage ......................................................................
mediatek/mt8183: Overlap decompressor, verstage and romstage
Since SRAM space is too small to fit all needed features, enable VBOOT_RETURN_FROM_VERSTAGE and overlap decompressor, verstage and romstage to gain more space.
BUG=b:134351649 BRANCH=none TEST=emerge-kukui coreboot
Change-Id: Ibe336cf93b01fa2ea57b4c2e0a89685424878c91 Signed-off-by: Tristan Shieh tristan.shieh@mediatek.com --- M src/soc/mediatek/mt8183/Kconfig M src/soc/mediatek/mt8183/include/soc/memlayout.ld 2 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/34871/2
Tristan Hsieh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34871 )
Change subject: mediatek/mt8183: Overlap decompressor, verstage and romstage ......................................................................
Patch Set 2:
Patch Set 1: Code-Review+2
Note that there's also an OVERLAP_DECOMPRESSOR_VERSTAGE_ROMSTAGE() if you want to overlap all the things. ;)
Thanks.
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34871 )
Change subject: mediatek/mt8183: Overlap decompressor, verstage and romstage ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34871 )
Change subject: mediatek/mt8183: Overlap decompressor, verstage and romstage ......................................................................
mediatek/mt8183: Overlap decompressor, verstage and romstage
Since SRAM space is too small to fit all needed features, enable VBOOT_RETURN_FROM_VERSTAGE and overlap decompressor, verstage and romstage to gain more space.
BUG=b:134351649 BRANCH=none TEST=emerge-kukui coreboot
Change-Id: Ibe336cf93b01fa2ea57b4c2e0a89685424878c91 Signed-off-by: Tristan Shieh tristan.shieh@mediatek.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/34871 Reviewed-by: Hung-Te Lin hungte@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/mediatek/mt8183/Kconfig M src/soc/mediatek/mt8183/include/soc/memlayout.ld 2 files changed, 3 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Hung-Te Lin: Looks good to me, approved
diff --git a/src/soc/mediatek/mt8183/Kconfig b/src/soc/mediatek/mt8183/Kconfig index c60cdea..9ac57bd 100644 --- a/src/soc/mediatek/mt8183/Kconfig +++ b/src/soc/mediatek/mt8183/Kconfig @@ -15,6 +15,7 @@ select VBOOT_MUST_REQUEST_DISPLAY select VBOOT_STARTS_IN_BOOTBLOCK select VBOOT_SEPARATE_VERSTAGE + select VBOOT_RETURN_FROM_VERSTAGE
config DEBUG_DRAM bool "Output verbose DRAM related debug messages" diff --git a/src/soc/mediatek/mt8183/include/soc/memlayout.ld b/src/soc/mediatek/mt8183/include/soc/memlayout.ld index 6a11a0e..d8d5f66 100644 --- a/src/soc/mediatek/mt8183/include/soc/memlayout.ld +++ b/src/soc/mediatek/mt8183/include/soc/memlayout.ld @@ -40,9 +40,8 @@ SRAM_END(0x00120000)
SRAM_L2C_START(0x00200000) - OVERLAP_DECOMPRESSOR_ROMSTAGE(0x000201000, 152K) - BOOTBLOCK(0x00227000, 89K) - VERSTAGE(0x0023E000, 114K) + OVERLAP_DECOMPRESSOR_VERSTAGE_ROMSTAGE(0x00201000, 188K) + BOOTBLOCK(0x00230000, 64K) SRAM_L2C_END(0x00280000)
DRAM_START(0x40000000)
-
Hung-Te Lin (Code Review) -
Julius Werner (Code Review)
-
Patrick Georgi (Code Review)
-
Tristan Hsieh (Code Review)