Nick Vaccaro has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39300 )
Change subject: mb/google/volteer: make variant_early_gpio_table weak ......................................................................
mb/google/volteer: make variant_early_gpio_table weak
Declare variant_early_gpio_table() weak to allow override by variants.
BUG=b:148385924, b:150810535 TEST=none
Change-Id: Ife5e3b75256f71ecd763c4000fd2c7d7c927bb64 Signed-off-by: Nick Vaccaro nvaccaro@google.com --- M src/mainboard/google/volteer/variants/baseboard/gpio.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/39300/1
diff --git a/src/mainboard/google/volteer/variants/baseboard/gpio.c b/src/mainboard/google/volteer/variants/baseboard/gpio.c index 2dc340f..3f1f2b0 100644 --- a/src/mainboard/google/volteer/variants/baseboard/gpio.c +++ b/src/mainboard/google/volteer/variants/baseboard/gpio.c @@ -452,7 +452,7 @@ return NULL; }
-const struct pad_config *variant_early_gpio_table(size_t *num) +const struct pad_config *__weak variant_early_gpio_table(size_t *num) { *num = ARRAY_SIZE(early_gpio_table); return early_gpio_table;
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39300 )
Change subject: mb/google/volteer: make variant_early_gpio_table weak ......................................................................
Patch Set 1: Code-Review+2
caveh jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39300 )
Change subject: mb/google/volteer: make variant_early_gpio_table weak ......................................................................
Patch Set 1: Code-Review+1
Srinidhi N Kaushik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39300 )
Change subject: mb/google/volteer: make variant_early_gpio_table weak ......................................................................
Patch Set 1: Code-Review+1
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39300 )
Change subject: mb/google/volteer: make variant_early_gpio_table weak ......................................................................
mb/google/volteer: make variant_early_gpio_table weak
Declare variant_early_gpio_table() weak to allow override by variants.
BUG=b:148385924, b:150810535 TEST=none
Change-Id: Ife5e3b75256f71ecd763c4000fd2c7d7c927bb64 Signed-off-by: Nick Vaccaro nvaccaro@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/39300 Reviewed-by: Furquan Shaikh furquan@google.com Reviewed-by: caveh jalali caveh@chromium.org Reviewed-by: Srinidhi N Kaushik srinidhi.n.kaushik@intel.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/volteer/variants/baseboard/gpio.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved Srinidhi N Kaushik: Looks good to me, but someone else must approve caveh jalali: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/volteer/variants/baseboard/gpio.c b/src/mainboard/google/volteer/variants/baseboard/gpio.c index 2dc340f..3f1f2b0 100644 --- a/src/mainboard/google/volteer/variants/baseboard/gpio.c +++ b/src/mainboard/google/volteer/variants/baseboard/gpio.c @@ -452,7 +452,7 @@ return NULL; }
-const struct pad_config *variant_early_gpio_table(size_t *num) +const struct pad_config *__weak variant_early_gpio_table(size_t *num) { *num = ARRAY_SIZE(early_gpio_table); return early_gpio_table;