Change in coreboot[master]: mb/asus/p8z77-m_pro: Conistently spell *PRO* in board name uppercase
Paul Menzel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39350 )
Change subject: mb/asus/p8z77-m_pro: Conistently spell *PRO* in board name uppercase ......................................................................
mb/asus/p8z77-m_pro: Conistently spell *PRO* in board name uppercase
Change-Id: I2e2d62389d1b965f4a391080a10e7f97fa787d14 Signed-off-by: Paul Menzel pmenzel@molgen.mpg.de --- M Documentation/mainboard/asus/p8z77-m_pro.md M src/mainboard/asus/p8z77-m_pro/early_init.c 2 files changed, 4 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/39350/1
diff --git a/Documentation/mainboard/asus/p8z77-m_pro.md b/Documentation/mainboard/asus/p8z77-m_pro.md index 2d9f612..1101089 100644 --- a/Documentation/mainboard/asus/p8z77-m_pro.md +++ b/Documentation/mainboard/asus/p8z77-m_pro.md @@ -1,6 +1,6 @@ -# ASUS P8Z77-M Pro +# ASUS P8Z77-M PRO
-This page describes how to run coreboot on the [ASUS P8Z77-M Pro] +This page describes how to run coreboot on the [ASUS P8Z77-M PRO]
## Flashing coreboot
@@ -163,6 +163,6 @@
- [Flash chip datasheet][W25Q64FVA1Q]
-[ASUS P8Z77-M Pro]: https://www.asus.com/Motherboards/P8Z77M_PRO/ +[ASUS P8Z77-M PRO]: https://www.asus.com/Motherboards/P8Z77M_PRO/ [W25Q64FVA1Q]: https://www.winbond.com/resource-files/w25q64fv%20revs%2007182017.pdf [flashrom]: https://flashrom.org/Flashrom diff --git a/src/mainboard/asus/p8z77-m_pro/early_init.c b/src/mainboard/asus/p8z77-m_pro/early_init.c index 6c76a7a..d2c2355 100644 --- a/src/mainboard/asus/p8z77-m_pro/early_init.c +++ b/src/mainboard/asus/p8z77-m_pro/early_init.c @@ -154,7 +154,7 @@ */ usb3_streams }, - /* ASUS P8Z77-M Pro manual says 1.35v DIMMs are supported */ + /* ASUS P8Z77-M PRO manual says 1.35v DIMMs are supported */ .ddr3lv_support = 1, /* PCIe 3.0 support. As we use Ivy Bridge, let's enable it, * but might cause some system instability !
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39350 )
Change subject: mb/asus/p8z77-m_pro: Conistently spell *PRO* in board name uppercase ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/39350/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39350/1//COMMIT_MSG@7 PS1, Line 7: Conistently Missing an `s`: Con*s*istently
Alternatively, use a shorter commit summary, e.g.:
mb/asus/p8z77-m_pro: Use uppercase for `PRO`
And explain a bit in the commit message body
Hello build bot (Jenkins), Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39350
to look at the new patch set (#2).
Change subject: mb/asus/p8z77-m_pro: Use uppercase for *PRO* ......................................................................
mb/asus/p8z77-m_pro: Use uppercase for *PRO*
Consistently use the official uppercase spelling.
Change-Id: I2e2d62389d1b965f4a391080a10e7f97fa787d14 Signed-off-by: Paul Menzel pmenzel@molgen.mpg.de --- M Documentation/mainboard/asus/p8z77-m_pro.md M src/mainboard/asus/p8z77-m_pro/early_init.c 2 files changed, 4 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/39350/2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39350 )
Change subject: mb/asus/p8z77-m_pro: Use uppercase for *PRO* ......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/39350/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39350/1//COMMIT_MSG@7 PS1, Line 7: Conistently
Missing an `s`: Con*s*istently […]
Done
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39350 )
Change subject: mb/asus/p8z77-m_pro: Use uppercase for *PRO* ......................................................................
mb/asus/p8z77-m_pro: Use uppercase for *PRO*
Consistently use the official uppercase spelling.
Change-Id: I2e2d62389d1b965f4a391080a10e7f97fa787d14 Signed-off-by: Paul Menzel pmenzel@molgen.mpg.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/39350 Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M Documentation/mainboard/asus/p8z77-m_pro.md M src/mainboard/asus/p8z77-m_pro/early_init.c 2 files changed, 4 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/Documentation/mainboard/asus/p8z77-m_pro.md b/Documentation/mainboard/asus/p8z77-m_pro.md index 2d9f612..1101089 100644 --- a/Documentation/mainboard/asus/p8z77-m_pro.md +++ b/Documentation/mainboard/asus/p8z77-m_pro.md @@ -1,6 +1,6 @@ -# ASUS P8Z77-M Pro +# ASUS P8Z77-M PRO
-This page describes how to run coreboot on the [ASUS P8Z77-M Pro] +This page describes how to run coreboot on the [ASUS P8Z77-M PRO]
## Flashing coreboot
@@ -163,6 +163,6 @@
- [Flash chip datasheet][W25Q64FVA1Q]
-[ASUS P8Z77-M Pro]: https://www.asus.com/Motherboards/P8Z77M_PRO/ +[ASUS P8Z77-M PRO]: https://www.asus.com/Motherboards/P8Z77M_PRO/ [W25Q64FVA1Q]: https://www.winbond.com/resource-files/w25q64fv%20revs%2007182017.pdf [flashrom]: https://flashrom.org/Flashrom diff --git a/src/mainboard/asus/p8z77-m_pro/early_init.c b/src/mainboard/asus/p8z77-m_pro/early_init.c index 6c76a7a..d2c2355 100644 --- a/src/mainboard/asus/p8z77-m_pro/early_init.c +++ b/src/mainboard/asus/p8z77-m_pro/early_init.c @@ -154,7 +154,7 @@ */ usb3_streams }, - /* ASUS P8Z77-M Pro manual says 1.35v DIMMs are supported */ + /* ASUS P8Z77-M PRO manual says 1.35v DIMMs are supported */ .ddr3lv_support = 1, /* PCIe 3.0 support. As we use Ivy Bridge, let's enable it, * but might cause some system instability !
-
Angel Pons (Code Review) -
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)