Attention is currently required from: Paul Menzel.
Poornima Tom has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81654?usp=email )
Change subject: mb/google/brox: Update verb table to fix headset detection ......................................................................
Patch Set 2:
(11 comments)
This change is ready for review.
Commit Message:
https://review.coreboot.org/c/coreboot/+/81654/comment/504aa2d9_ef99ba05 : PS1, Line 2: poornima tom
More common spelling is: Poornima Tom. […]
Done
https://review.coreboot.org/c/coreboot/+/81654/comment/f8ec96a9_9f8ddc7c : PS1, Line 7: Correct verbtable value
More specific: […]
Done
https://review.coreboot.org/c/coreboot/+/81654/comment/70c3f6ed_5543b4d0 : PS1, Line 7: mb/google/brox:Correct
Please add a space after the colon.
Done
https://review.coreboot.org/c/coreboot/+/81654/comment/fd1401ee_3c286f3e : PS1, Line 9: pinwidget
pin widget [1] […]
Done
https://review.coreboot.org/c/coreboot/+/81654/comment/ea2bc9ff_9aa19fab : PS1, Line 9: Corrected
Imperative mood: Correct ….
Done
https://review.coreboot.org/c/coreboot/+/81654/comment/1a8d4544_96150df8 : PS1, Line 9: pinwidget 20
… of the Realtek ALC256 …
Done
https://review.coreboot.org/c/coreboot/+/81654/comment/935e4ac5_4569978c : PS1, Line 10: the updated verbtable received from Realtek
Please document the version/revision.
Done
https://review.coreboot.org/c/coreboot/+/81654/comment/2171afda_492c8d03 : PS1, Line 11: This fixes the headset detection failure, when : runtime suspend is enabled
Please add a dot/period at the end of sentences.
Done
https://review.coreboot.org/c/coreboot/+/81654/comment/1170bd1d_854ca517 : PS1, Line 9: Corrected verbtable value for pinwidget 20 based : on the updated verbtable received from Realtek. : This fixes the headset detection failure, when : runtime suspend is enabled
Please use 72 characters per line.
Done
https://review.coreboot.org/c/coreboot/+/81654/comment/cc9e293e_a6354912 : PS1, Line 16: under runtime suspend
What does that mean exactly? When the device is S0ix suspended, then plugging in a headset to the au […]
reframed.
https://review.coreboot.org/c/coreboot/+/81654/comment/2ec67884_e881eeff : PS1, Line 16: TEST=verified headset on Brox, under runtime suspend
I guess connected to the audio jack and no USB headset.
ys , not on USB headset, but audio jack