EricR Lai has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36535 )
Change subject: mb/google/drallion: Correct GPP_E7 as stop pin ......................................................................
mb/google/drallion: Correct GPP_E7 as stop pin
Current desgin reset pin is connected to PLTRST. GPP_E7 is stop pin for touch. Reserve reset pin for next stage implement.
BUG=b:143733039 BRANCH=N/A TEST=check touch screen can work properly
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: I3ebd56ab49b87da425583da04f082e69293a023e --- M src/mainboard/google/drallion/variants/drallion/devicetree.cb 1 file changed, 6 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/36535/1
diff --git a/src/mainboard/google/drallion/variants/drallion/devicetree.cb b/src/mainboard/google/drallion/variants/drallion/devicetree.cb index 0de2e94..ed44f4f 100644 --- a/src/mainboard/google/drallion/variants/drallion/devicetree.cb +++ b/src/mainboard/google/drallion/variants/drallion/devicetree.cb @@ -322,8 +322,8 @@ register "generic.desc" = ""Wacom Touchscreen"" register "generic.irq" = "ACPI_IRQ_LEVEL_LOW(GPP_C23_IRQ)" register "generic.probed" = "1" - register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_E7)" - register "generic.reset_delay_ms" = "20" + register "generic.stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_E7)" + register "generic.stop_delay_ms" = "20" register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_B21)" register "generic.enable_delay_ms" = "55" register "generic.has_power_resource" = "1" @@ -338,9 +338,9 @@ register "generic.desc" = ""ELAN Touchscreen"" register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPP_C23_IRQ)" register "generic.probed" = "1" - register "generic.reset_gpio" = + register "generic.stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_E7)" - register "generic.reset_delay_ms" = "10" + register "generic.stop_delay_ms" = "10" register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_B21)" register "generic.enable_delay_ms" = "55" @@ -355,8 +355,8 @@ register "desc" = ""Melfas Touchscreen"" register "irq" = "ACPI_IRQ_EDGE_LOW(GPP_C23_IRQ)" register "probed" = "1" - register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_E7)" - register "reset_delay_ms" = "10" + register "stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_E7)" + register "stop_delay_ms" = "10" register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_B21)" register "enable_delay_ms" = "55" register "has_power_resource" = "1"
Mathew King has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36535 )
Change subject: mb/google/drallion: Correct GPP_E7 as stop pin ......................................................................
Patch Set 1: Code-Review+2
Bora Guvendik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36535 )
Change subject: mb/google/drallion: Correct GPP_E7 as stop pin ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36535/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36535/1//COMMIT_MSG@9 PS1, Line 9: desgin design
Hello Ivy Jian, Mathew King, Bora Guvendik, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36535
to look at the new patch set (#2).
Change subject: mb/google/drallion: Correct GPP_E7 as stop pin ......................................................................
mb/google/drallion: Correct GPP_E7 as stop pin
Current design reset pin is connected to PLTRST. GPP_E7 is stop pin for touch. Reserve reset pin for next stage implement.
BUG=b:143733039 BRANCH=N/A TEST=check touch screen can work properly
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: I3ebd56ab49b87da425583da04f082e69293a023e --- M src/mainboard/google/drallion/variants/drallion/devicetree.cb 1 file changed, 6 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/36535/2
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36535 )
Change subject: mb/google/drallion: Correct GPP_E7 as stop pin ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36535/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36535/1//COMMIT_MSG@9 PS1, Line 9: desgin
design
Done
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36535 )
Change subject: mb/google/drallion: Correct GPP_E7 as stop pin ......................................................................
mb/google/drallion: Correct GPP_E7 as stop pin
Current design reset pin is connected to PLTRST. GPP_E7 is stop pin for touch. Reserve reset pin for next stage implement.
BUG=b:143733039 BRANCH=N/A TEST=check touch screen can work properly
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: I3ebd56ab49b87da425583da04f082e69293a023e Reviewed-on: https://review.coreboot.org/c/coreboot/+/36535 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Mathew King mathewk@chromium.org --- M src/mainboard/google/drallion/variants/drallion/devicetree.cb 1 file changed, 6 insertions(+), 6 deletions(-)
Approvals: build bot (Jenkins): Verified Mathew King: Looks good to me, approved
diff --git a/src/mainboard/google/drallion/variants/drallion/devicetree.cb b/src/mainboard/google/drallion/variants/drallion/devicetree.cb index 0de2e94..ed44f4f 100644 --- a/src/mainboard/google/drallion/variants/drallion/devicetree.cb +++ b/src/mainboard/google/drallion/variants/drallion/devicetree.cb @@ -322,8 +322,8 @@ register "generic.desc" = ""Wacom Touchscreen"" register "generic.irq" = "ACPI_IRQ_LEVEL_LOW(GPP_C23_IRQ)" register "generic.probed" = "1" - register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_E7)" - register "generic.reset_delay_ms" = "20" + register "generic.stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_E7)" + register "generic.stop_delay_ms" = "20" register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_B21)" register "generic.enable_delay_ms" = "55" register "generic.has_power_resource" = "1" @@ -338,9 +338,9 @@ register "generic.desc" = ""ELAN Touchscreen"" register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPP_C23_IRQ)" register "generic.probed" = "1" - register "generic.reset_gpio" = + register "generic.stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_E7)" - register "generic.reset_delay_ms" = "10" + register "generic.stop_delay_ms" = "10" register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_B21)" register "generic.enable_delay_ms" = "55" @@ -355,8 +355,8 @@ register "desc" = ""Melfas Touchscreen"" register "irq" = "ACPI_IRQ_EDGE_LOW(GPP_C23_IRQ)" register "probed" = "1" - register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_E7)" - register "reset_delay_ms" = "10" + register "stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_E7)" + register "stop_delay_ms" = "10" register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_B21)" register "enable_delay_ms" = "55" register "has_power_resource" = "1"
-
Bora Guvendik (Code Review) -
EricR Lai (Code Review)
-
Mathew King (Code Review)
-
Patrick Georgi (Code Review)