build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29563 )
Change subject: security/tpm: Fix TCPA log feature ......................................................................
Patch Set 47:
(14 comments)
https://review.coreboot.org/#/c/29563/47/src/include/memlayout.h File src/include/memlayout.h:
https://review.coreboot.org/#/c/29563/47/src/include/memlayout.h@167 PS47, Line 167: #define VBOOT2_TPM_LOG(addr, size) \ Macros with multiple statements should be enclosed in a do - while loop
https://review.coreboot.org/#/c/29563/47/src/include/memlayout.h@167 PS47, Line 167: #define VBOOT2_TPM_LOG(addr, size) \ macros should not use a trailing semicolon
https://review.coreboot.org/#/c/29563/47/src/security/tpm/tspi.h File src/security/tpm/tspi.h:
https://review.coreboot.org/#/c/29563/47/src/security/tpm/tspi.h@62 PS47, Line 62: uint32_t tpm_extend_pcr(int pcr, const char *digest_type, uint8_t *digest, size_t digest_len, line over 80 characters
https://review.coreboot.org/#/c/29563/47/src/security/tpm/tspi/log.c File src/security/tpm/tspi/log.c:
https://review.coreboot.org/#/c/29563/47/src/security/tpm/tspi/log.c@35 PS47, Line 35: size_t tcpa_log_len = sizeof(struct tcpa_table) + MAX_TCPA_LOG_ENTRIES * sizeof(struct tcpa_entry); line over 80 characters
https://review.coreboot.org/#/c/29563/47/src/security/tpm/tspi/log.c@53 PS47, Line 53: if (!cbmem_possibly_online() && IS_ENABLED(CONFIG_VBOOT_TCPA_LOG_RECOVERY)) line over 80 characters
https://review.coreboot.org/#/c/29563/47/src/security/tpm/tspi/log.c@95 PS47, Line 95: void tcpa_log_add_table_entry(const char *name, const uint32_t pcr, const char *digest_type, line over 80 characters
https://review.coreboot.org/#/c/29563/47/src/security/tpm/tspi/log.c@160 PS47, Line 160: struct tcpa_entry *tce = &ram_log->entries[ram_log->num_entries++]; line over 80 characters
https://review.coreboot.org/#/c/29563/47/src/security/tpm/tspi/log.c@161 PS47, Line 161: strncpy(tce->name, preram_log->entries[i].name, TCPA_PCR_HASH_NAME - 1); line over 80 characters
https://review.coreboot.org/#/c/29563/47/src/security/tpm/tspi/log.c@164 PS47, Line 164: if (preram_log->entries[i].digest_length > TCPA_DIGEST_MAX_LENGTH) { line over 80 characters
https://review.coreboot.org/#/c/29563/47/src/security/tpm/tspi/log.c@169 PS47, Line 169: strncpy(tce->digest_type, preram_log->entries[i].digest_type, TCPA_PCR_HASH_LEN - 1); line over 80 characters
https://review.coreboot.org/#/c/29563/47/src/security/tpm/tspi/log.c@170 PS47, Line 170: tce->digest_length = MIN(preram_log->entries[i].digest_length, TCPA_DIGEST_MAX_LENGTH); line over 80 characters
https://review.coreboot.org/#/c/29563/47/src/security/tpm/tspi/log.c@171 PS47, Line 171: memcpy(tce->digest, preram_log->entries[i].digest, tce->digest_length); line over 80 characters
https://review.coreboot.org/#/c/29563/47/src/security/tpm/tspi/tspi.c File src/security/tpm/tspi/tspi.c:
https://review.coreboot.org/#/c/29563/47/src/security/tpm/tspi/tspi.c@247 PS47, Line 247: strncpy(hash_name, vb2_get_hash_algorithm_name(hash_alg), TCPA_PCR_HASH_LEN - 1); line over 80 characters
https://review.coreboot.org/#/c/29563/47/src/security/vboot/secdata_tpm.c File src/security/vboot/secdata_tpm.c:
https://review.coreboot.org/#/c/29563/47/src/security/vboot/secdata_tpm.c@86 PS47, Line 86: return tpm_extend_pcr(pcr, "SHA256", buffer, size, TPM_PCR_GBB_HWID_NAME); line over 80 characters
-
build bot (Jenkins) (Code Review)