[S] Change in coreboot[main]: lib: Refactor bmp_load_logo() implementation

[Subrata Banik (Code Review)]

Attention is currently required from: Andrey Petrov, Felix Held, Fred Reitberger, Jason Glenesk, Julius Werner, Matt DeVillier, Ronak Kanabar, Sean Rhodes.

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81618?usp=email )

Change subject: lib: Refactor bmp_load_logo() implementation
......................................................................

Patch Set 3:

(2 comments)

File src/drivers/intel/fsp1_1/ramstage.c:

https://review.coreboot.org/c/coreboot/+/81618/comment/88ae012c_345579d5 :
PS3, Line 81: uint32_t
> I don't think this would compile for 64-bit. Better make this a cast to `uintptr_t`. (You can leave the narrowing conversion from there to `uint32_t` implicit or add another cast in front of that.)
>
> Same issue at most other call sites.

is this what you meant ? `PcdLogoPtr` is UINT32 type.
```
silicon_init_params.PcdLogoPtr = (uint32_t)(uintptr_t)bmp_load_logo(&logo_size);
```

File src/drivers/intel/fsp2_0/fsp_gop_blt.c:

https://review.coreboot.org/c/coreboot/+/81618/comment/f5ba1a03_ce87ebdd :
PS3, Line 241: logo_size_t
> `_t` is usually a suffix for types, not variable identifiers.

sorry for not being thoughtful with the variable name. I will do the change to make the variable name meaningful here,.
> Why not just change `logo_ptr_size` to a `size_t`?

https://review.coreboot.org/c/coreboot/+/81615/7/src/drivers/intel/fsp2_0/fs... CL is dropping the temp variable. just keeping CLs meaningful