Change in coreboot[master]: mb/google/dedede/var/waddledee: Enable GPIO based I2C Multiplexer - coreboot-gerrit

16 Oct 2020


      Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45912 )
Change subject: mb/google/dedede/var/waddledee: Enable GPIO based I2C Multiplexer
......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45912/8/src/mainboard/google/dedede... 
File src/mainboard/google/dedede/variants/waddledee/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/45912/8/src/mainboard/google/dedede... 
PS8, Line 125: ACPI_GPIO_OUTPUT_ACTIVE_HIGH
I think this should be just ACPI_GPIO_OUTPUT. Polarity doesn't really mean anything here.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/45912
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9b09e063b4377587019ade9e6e194f4aadcdd312
Gerrit-Change-Number: 45912
Gerrit-PatchSet: 8
Gerrit-Owner: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Evan Green evgreen@chromium.org
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Justin TerAvest teravest@chromium.org
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 15 Oct 2020 22:11:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment