Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37183 )
Change subject: mb/samsung: remove header guards for SuperIO ......................................................................
mb/samsung: remove header guards for SuperIO
SuperIO header needs to be included regardless of Kconfig option, otherwise compilation fails due to missing prototype for try_enabling_LPC47N207_uart() if DRIVERS_UART_8250IO is not set.
Change-Id: I0eda4aee2cbb114bde33e862940a64675469693d Signed-off-by: Matt DeVillier matt.devillier@gmail.com --- M src/mainboard/samsung/lumpy/early_init.c M src/mainboard/samsung/stumpy/early_init.c 2 files changed, 1 insertion(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/37183/1
diff --git a/src/mainboard/samsung/lumpy/early_init.c b/src/mainboard/samsung/lumpy/early_init.c index af4e55d..28cd5c3 100644 --- a/src/mainboard/samsung/lumpy/early_init.c +++ b/src/mainboard/samsung/lumpy/early_init.c @@ -29,10 +29,8 @@ #include <northbridge/intel/sandybridge/raminit_native.h> #include <southbridge/intel/bd82x6x/pch.h> #include <southbridge/intel/common/gpio.h> -#include "option_table.h" -#if CONFIG(DRIVERS_UART_8250IO) #include <superio/smsc/lpc47n207/lpc47n207.h> -#endif +#include "option_table.h"
void bootblock_mainboard_early_init(void) { diff --git a/src/mainboard/samsung/stumpy/early_init.c b/src/mainboard/samsung/stumpy/early_init.c index 7fca8ad..157fdf1 100644 --- a/src/mainboard/samsung/stumpy/early_init.c +++ b/src/mainboard/samsung/stumpy/early_init.c @@ -29,9 +29,7 @@ #include <northbridge/intel/sandybridge/raminit_native.h> #include <southbridge/intel/bd82x6x/pch.h> #include <southbridge/intel/common/gpio.h> -#if CONFIG(DRIVERS_UART_8250IO) #include <superio/smsc/lpc47n207/lpc47n207.h> -#endif
/* Stumpy USB Reset Disable defined in cmos.layout */ #if CONFIG(USE_OPTION_TABLE)
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37183 )
Change subject: mb/samsung: remove header guards for SuperIO ......................................................................
Patch Set 1: Code-Review+2
At least lumpy needs additional debug hardware on it's LPC connector to have SUPERIO. The default is wrong here, these boards should select NO_UART_ON_SUPERIO?
config DRIVERS_UART_8250IO # FIXME: Shouldn't have a prompt, should default to n, and # should be selected by boards that have it instead.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37183 )
Change subject: mb/samsung: remove header guards for SuperIO ......................................................................
Patch Set 1:
correct, neither of these devices have serial output without additional hardware
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37183 )
Change subject: mb/samsung: remove header guards for SuperIO ......................................................................
Patch Set 1: Code-Review+1
Patch Set 1:
correct, neither of these devices have serial output without additional hardware
I wonder serial output is actually coming from the IT8772F SIO
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37183 )
Change subject: mb/samsung: remove header guards for SuperIO ......................................................................
Patch Set 1: Code-Review+2
If it's just somebody's debug code, we can remove it... but let's fix the build first.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37183 )
Change subject: mb/samsung: remove header guards for SuperIO ......................................................................
Patch Set 1: Code-Review+2
Patch Set 1: Code-Review+1
Patch Set 1:
correct, neither of these devices have serial output without additional hardware
I wonder serial output is actually coming from the IT8772F SIO
Just checked internet pictures, the chromebook has a SMSC MEC1310-NU and the chromebox has an ITE IT8772F on the board. I guess this is just debug code as there is no LPC47N207 on the board, and that SuperIO is rather old (saw it being used on a Pentium 4 Northwood mainboard).
Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37183 )
Change subject: mb/samsung: remove header guards for SuperIO ......................................................................
mb/samsung: remove header guards for SuperIO
SuperIO header needs to be included regardless of Kconfig option, otherwise compilation fails due to missing prototype for try_enabling_LPC47N207_uart() if DRIVERS_UART_8250IO is not set.
Change-Id: I0eda4aee2cbb114bde33e862940a64675469693d Signed-off-by: Matt DeVillier matt.devillier@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/37183 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-by: Nico Huber nico.h@gmx.de Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/samsung/lumpy/early_init.c M src/mainboard/samsung/stumpy/early_init.c 2 files changed, 1 insertion(+), 5 deletions(-)
Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, approved Nico Huber: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/src/mainboard/samsung/lumpy/early_init.c b/src/mainboard/samsung/lumpy/early_init.c index af4e55d..28cd5c3 100644 --- a/src/mainboard/samsung/lumpy/early_init.c +++ b/src/mainboard/samsung/lumpy/early_init.c @@ -29,10 +29,8 @@ #include <northbridge/intel/sandybridge/raminit_native.h> #include <southbridge/intel/bd82x6x/pch.h> #include <southbridge/intel/common/gpio.h> -#include "option_table.h" -#if CONFIG(DRIVERS_UART_8250IO) #include <superio/smsc/lpc47n207/lpc47n207.h> -#endif +#include "option_table.h"
void bootblock_mainboard_early_init(void) { diff --git a/src/mainboard/samsung/stumpy/early_init.c b/src/mainboard/samsung/stumpy/early_init.c index 7fca8ad..157fdf1 100644 --- a/src/mainboard/samsung/stumpy/early_init.c +++ b/src/mainboard/samsung/stumpy/early_init.c @@ -29,9 +29,7 @@ #include <northbridge/intel/sandybridge/raminit_native.h> #include <southbridge/intel/bd82x6x/pch.h> #include <southbridge/intel/common/gpio.h> -#if CONFIG(DRIVERS_UART_8250IO) #include <superio/smsc/lpc47n207/lpc47n207.h> -#endif
/* Stumpy USB Reset Disable defined in cmos.layout */ #if CONFIG(USE_OPTION_TABLE)
-
Angel Pons (Code Review) -
Kyösti Mälkki (Code Review)
-
Matt DeVillier (Code Review)
-
Nico Huber (Code Review)