Attention is currently required from: Felix Singer. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61531 )
Change subject: include/devices/pci_ids.h: Rework indentations ......................................................................
Patch Set 8:
(1 comment)
File src/include/device/pci_ids.h:
https://review.coreboot.org/c/coreboot/+/61531/comment/21388756_e9ec3d16 PS8, Line 265: /* Rage128 GL */ : #define PCI_DID_ATI_RAGE128_RE 0x5245 : #define PCI_DID_ATI_RAGE128_RF 0x5246 : #define PCI_DID_ATI_RAGE128_RG 0x534b : #define PCI_DID_ATI_RAGE128_RH 0x534c : #define PCI_DID_ATI_RAGE128_RI 0x534d : /* Rage128 VR */ : #define PCI_DID_ATI_RAGE128_RK 0x524b : #define PCI_DID_ATI_RAGE128_RL 0x524c : #define PCI_DID_ATI_RAGE128_RM 0x5345 : #define PCI_DID_ATI_RAGE128_RN 0x5346 : #define PCI_DID_ATI_RAGE128_RO 0x5347 : /* Rage128 M3 */ : #define PCI_DID_ATI_RAGE128_LE 0x4c45 : #define PCI_DID_ATI_RAGE128_LF 0x4c46 : /* Rage128 Pro Ultra */ : #define PCI_DID_ATI_RAGE128_U1 0x5446 : #define PCI_DID_ATI_RAGE128_U2 0x544C : #define PCI_DID_ATI_RAGE128_U3 0x5452 : /* Radeon M4 */ : #define PCI_DID_ATI_RADEON_LE 0x4d45 : #define PCI_DID_ATI_RADEON_LF 0x4d46 : /* Radeon NV-100 */ : #define PCI_DID_ATI_RADEON_N1 0x5159 : #define PCI_DID_ATI_RADEON_N2 0x515a : /* Radeon */ : #define PCI_DID_ATI_RADEON_RA 0x5144 : #define PCI_DID_ATI_RADEON_RB 0x5145 : #define PCI_DID_ATI_RADEON_RC 0x5146 : #define PCI_DID_ATI_RADEON_RD 0x5147 : : #define PCI_DID_ATI_SB600_LPC 0x438D : #define PCI_DID_ATI_SB600_SATA 0x4380 : #define PCI_DID_ATI_SB600_IDE 0x438C : #define PCI_DID_ATI_SB600_HDA 0x4383 : #define PCI_DID_ATI_SB600_ACI 0x4382 : #define PCI_DID_ATI_SB600_MCI 0x438E : #define PCI_DID_ATI_SB600_USB2 0x4386 : #define PCI_DID_ATI_SB600_PCI 0x4384 : #define PCI_DID_ATI_SB600_SM 0x4385 : #define PCI_DID_ATI_SB600_USB_0 0x4387 : #define PCI_DID_ATI_SB600_USB_1 0x4388 hmm, maybe align all ids in the whole file?
-
Michael Niewöhner (Code Review)